Update client.go: set peer.address tag from req.URL.Host; log hostPort in getConn() #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while creating spans for outbound requests,
http.url
tag is set In RoundTripper here:go-stdlib/nethttp/client.go
Line 188 in 60eb967
but, if
clientTrace
is enabled, this http.url is overriden ingetConn()
with host:port. This leaves span with poorer data with just host:port instead of complete (sanitised, ifURLTagFunc
was passed) url.Some tools like https://www.hypertrace.org/ depend on
http.url
tag to determine backends of a service, for which they require a complete url.Edit: based on conversation in #3 (comment), made changes to set
peer.address
tag & loghostPort
ingetConn()