Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: OWNERS: cleanup coreos group #1553

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jbtrystram
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
Copy link
Contributor

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for cleaning up the members that are no longer part of the CoreOS group.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@jbtrystram
Copy link
Contributor Author

/retitle NO-JIRA: OWNERS: cleanup coreos group

@openshift-ci openshift-ci bot changed the title OWNERS: cleanup NO-JIRA: OWNERS: cleanup coreos group Jul 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2024
@openshift-ci-robot
Copy link

@jbtrystram: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jlebon
Copy link
Member

jlebon commented Jul 17, 2024

@openshift-ci openshift-ci bot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 18, 2024
@travier
Copy link
Member

travier commented Jul 18, 2024

You probably need to rename the file to OWNER_ALIAS or something. I vaguely remember us losing access to this repo in the past due to some similar changes. Can you take a look at the history?

@jbtrystram
Copy link
Contributor Author

jbtrystram commented Jul 18, 2024

You probably need to rename the file to OWNER_ALIAS or something. I vaguely remember us losing access to this repo in the past due to some similar changes. Can you take a look at the history?

51c194d

https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#owners_aliases
The documentation is not really clear if sourcing from release will work. I looked around in the others openshift repos and all the repos that have a OWNERS_ALIASES also have a OWNERS file.

Yeah, it's confirmed by the automation. Let me revert.

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 18, 2024
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 18, 2024
These people left the coreos team.
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 18, 2024
@jlebon
Copy link
Member

jlebon commented Jul 22, 2024

/lgtm
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 22, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbtrystram, jlebon, marmijo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jbtrystram,jlebon,marmijo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2399f3f into openshift:master Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants