-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prow: add a OWNERS file #3835
prow: add a OWNERS file #3835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the members, I find this to be a great idea. /lgtm
OWNERS
Outdated
- gursewak1997 | ||
- prestist | ||
- marmijo | ||
- RishabhSaini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rishab isn't part of our team at the moment, I think we can remove his credentials for now.
OWNERS
Outdated
- jschintag | ||
- c4rt0 | ||
- cverna | ||
- Adam0Brien |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
which is https://github.com/openshift/release/blob/master/OWNERS_ALIASES#L99 & https://github.com/openshift/release/blob/master/OWNERS_ALIASES#L119 Is something not working as expected? |
@travier I created that because I hit #3826 (comment) |
OK, let's get this list cleaned-up here (and in openshift/os as needed as well). |
and openshift/release as well |
@travier updated . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though note that we don't actually use Prow for approving or merging things in this repo. It's totally fine IMO to just manually merge things if one of the Prow tests is flaking and you know the change isn't covered by it anyway.
Hmm, but actually instead of this, don't we just want |
Note that you need to disable auto-merge to get the UI to bypass the checks. But I agree that it's only available to repo admins as it comes with risks. So overall it's better to have those Prow commands work. |
@jlebon from what I understand of the documentation, OWNER-ALIASES only work
yeah, did some more reading and testing, this does not work |
This allows us to have permissions to `/override` prow tests among other things. Currently this is limited to repo administrator but an OWNERS files makes it easier to manage. This matches the openshift/os repo.
This allows us to have permissions to
/override
prow tests among other things. Currently this is limited to repo administrator but an OWNERS files makes it easier to manage.This is a copy from the openshift/os repo.