Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow: add a OWNERS file #3835

Merged
merged 1 commit into from
Jul 22, 2024
Merged

prow: add a OWNERS file #3835

merged 1 commit into from
Jul 22, 2024

Conversation

jbtrystram
Copy link
Contributor

This allows us to have permissions to /override prow tests among other things. Currently this is limited to repo administrator but an OWNERS files makes it easier to manage.
This is a copy from the openshift/os repo.

@jbtrystram jbtrystram requested a review from jlebon July 17, 2024 07:30
Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the members, I find this to be a great idea. /lgtm

OWNERS Outdated
- gursewak1997
- prestist
- marmijo
- RishabhSaini
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rishab isn't part of our team at the moment, I think we can remove his credentials for now.

OWNERS Outdated
- jschintag
- c4rt0
- cverna
- Adam0Brien
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@travier
Copy link
Member

travier commented Jul 17, 2024

@travier
Copy link
Member

travier commented Jul 17, 2024

@jbtrystram
Copy link
Contributor Author

@travier I created that because I hit #3826 (comment)

@travier
Copy link
Member

travier commented Jul 17, 2024

OK, let's get this list cleaned-up here (and in openshift/os as needed as well).

@travier
Copy link
Member

travier commented Jul 17, 2024

and openshift/release as well

@jbtrystram
Copy link
Contributor Author

jlebon
jlebon previously approved these changes Jul 17, 2024
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though note that we don't actually use Prow for approving or merging things in this repo. It's totally fine IMO to just manually merge things if one of the Prow tests is flaking and you know the change isn't covered by it anyway.

@jlebon
Copy link
Member

jlebon commented Jul 17, 2024

Hmm, but actually instead of this, don't we just want OWNERS_ALIASES with the coreos-approvers alias? That way, we maintain a single list of users in openshift/release.

@jbtrystram
Copy link
Contributor Author

jbtrystram commented Jul 17, 2024

It's totally fine IMO to just manually merge things if one of the Prow tests is flaking and you know the change isn't covered by it anyway.

I am pretty sure I am not able to. I think only repository admins can merge ignoring checks.
image

I can't do anything more than this

@travier
Copy link
Member

travier commented Jul 18, 2024

Note that you need to disable auto-merge to get the UI to bypass the checks. But I agree that it's only available to repo admins as it comes with risks.

So overall it's better to have those Prow commands work.

@jbtrystram
Copy link
Contributor Author

@jlebon from what I understand of the documentation, OWNER-ALIASES only work

Hmm, but actually instead of this, don't we just want OWNERS_ALIASES with the coreos-approvers alias? That way, we maintain a single list of users in openshift/release.

yeah, did some more reading and testing, this does not work

This allows us to have permissions to `/override` prow tests among
other things. Currently this is limited to repo administrator but
an OWNERS files makes it easier to manage.
This matches the openshift/os repo.
@jlebon jlebon merged commit 6cf62cb into coreos:main Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants