Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POJO classes required for cluster state publication from remote #14006

Merged
merged 14 commits into from
Jun 11, 2024

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Jun 5, 2024

Description

Add the POJO classes required for publication of cluster state from remote repository.

Related Issues

Resolves #13791

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Cluster Manager ClusterManager:RemoteState enhancement Enhancement or improvement to existing feature or request labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 573e96f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for a1b0a70: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 661b44a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 9d73439: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for eef8768: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 99870a1:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for ed2e33e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for 830b002: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 added the v2.15.0 Issues and PRs related to version 2.15.0 label Jun 8, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for 8a10116: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 marked this pull request as ready for review June 9, 2024 15:12
@shiv0408 shiv0408 requested a review from anasalkouz as a code owner June 9, 2024 15:12
Copy link
Contributor

✅ Gradle check result for 20cb7c0: SUCCESS

Copy link
Contributor

❌ Gradle check result for f6d36c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 721bc18:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 721bc18: SUCCESS

@shwetathareja shwetathareja merged commit a9d2050 into opensearch-project:main Jun 11, 2024
30 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Jun 11, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14006-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a9d20502ae84148f564da33a82b13ba0f60ec8ac
# Push it to GitHub
git push --set-upstream origin backport/backport-14006-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-14006-to-2.x.

@shwetathareja
Copy link
Member

@shiv0408 please raise manual backport and update version checks accordingly.

shiv0408 added a commit to shiv0408/OpenSearch that referenced this pull request Jun 11, 2024
…pensearch-project#14006)

* Add POJO classes required for cluster state publication from remote
* Use InputStreams rather than XContent for serialization for ehpemeral objects
Signed-off-by: Shivansh Arora <[email protected]>

* Add remote routing table changes in diff Manifest
Signed-off-by: Arpit Bandejiya <[email protected]>

(cherry picked from commit a9d2050)
shwetathareja pushed a commit that referenced this pull request Jun 11, 2024
…14006) (#14172)

* Add POJO classes required for cluster state publication from remote
* Use InputStreams rather than XContent for serialization for ehpemeral objects
Signed-off-by: Shivansh Arora <[email protected]>

* Add remote routing table changes in diff Manifest
Signed-off-by: Arpit Bandejiya <[email protected]>

(cherry picked from commit a9d2050)
@shiv0408 shiv0408 deleted the remote_state_pojos branch June 11, 2024 19:12
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…pensearch-project#14006) (opensearch-project#14172)

* Add POJO classes required for cluster state publication from remote
* Use InputStreams rather than XContent for serialization for ehpemeral objects
Signed-off-by: Shivansh Arora <[email protected]>

* Add remote routing table changes in diff Manifest
Signed-off-by: Arpit Bandejiya <[email protected]>

(cherry picked from commit a9d2050)
Signed-off-by: kkewwei <[email protected]>
@shiv0408 shiv0408 self-assigned this Aug 5, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…pensearch-project#14006)

* Add POJO classes required for cluster state publication from remote
* Use InputStreams rather than XContent for serialization for ehpemeral objects
Signed-off-by: Shivansh Arora <[email protected]>

* Add remote routing table changes in diff Manifest
Signed-off-by: Arpit Bandejiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed Cluster Manager ClusterManager:RemoteState enhancement Enhancement or improvement to existing feature or request skip-changelog v2.15.0 Issues and PRs related to version 2.15.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Remote Cluster State] Create interfaces for remote cluster state
6 participants