Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove composeBuild fixture tasks when docker support not found #14357

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

finnegancarroll
Copy link
Contributor

@finnegancarroll finnegancarroll commented Jun 14, 2024

  • Skip ComposeBuild task without docker support.

Description

When running ./gradlew test composeBuild task is not skipped on systems without docker cli.

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 776e176: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 3ae436d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@finnegancarroll
Copy link
Contributor Author

Flaky test org.opensearch.cache.common.tier.TieredSpilloverCacheStatsIT.testIndicesLevelAggregation #14300

Copy link
Contributor

✅ Gradle check result for bc09a58: SUCCESS

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.73%. Comparing base (b15cb0c) to head (bc09a58).
Report is 450 commits behind head on main.

Files Patch % Lines
...search/gradle/testfixtures/TestFixturesPlugin.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14357      +/-   ##
============================================
+ Coverage     71.42%   71.73%   +0.31%     
- Complexity    59978    62084    +2106     
============================================
  Files          4985     5117     +132     
  Lines        282275   291713    +9438     
  Branches      40946    42168    +1222     
============================================
+ Hits         201603   209250    +7647     
- Misses        63999    65189    +1190     
- Partials      16673    17274     +601     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta added skip-changelog Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. backport 2.x Backport to 2.x branch labels Jun 18, 2024
@reta reta merged commit f8213b8 into opensearch-project:main Jun 18, 2024
38 of 41 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 18, 2024
Signed-off-by: Finn Carroll <[email protected]>
(cherry picked from commit f8213b8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@finnegancarroll finnegancarroll deleted the testfilt branch June 18, 2024 20:51
reta pushed a commit that referenced this pull request Jun 18, 2024
(cherry picked from commit f8213b8)

Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…14357) (opensearch-project#14440)

(cherry picked from commit f8213b8)

Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request ShardManagement:Resiliency skip-changelog
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants