Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DEPR USE-JWT-COOKIE header #35393

Merged
merged 1 commit into from
Aug 29, 2024
Merged

feat: DEPR USE-JWT-COOKIE header #35393

merged 1 commit into from
Aug 29, 2024

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Aug 28, 2024

This repo is no longer using USE-JWT-COOKIE header, since it has the required edx-drf-extensions>10.2.0, where it was fully removed.

This is final clean-up for this repo.

See "[DEPR]: USE-JWT-COOKIE header" for more details:

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@robrap
feat: DEPR USE-JWT-COOKIE header
936e0c7 
This repo is no longer using USE-JWT-COOKIE header,
since it has the required edx-drf-extensions>10.2.0,
where it was fully removed.

This is final clean-up for this repo.

See "[DEPR]: USE-JWT-COOKIE header" for more details:
- openedx/edx-drf-extensions#371
@robrap robrap requested a review from a team as a code owner August 28, 2024 21:01
@robrap robrap mentioned this pull request Aug 28, 2024
Open
21 tasks
@abdullahwaheed
Copy link
Contributor

@robrap since we are in transition to RV, we no longer own this code. Infinity is going to own this code so they can review it. thanks!

cc: @hurtstotouchfire

@robrap robrap merged commit 1c2b804 into master Aug 29, 2024
49 checks passed
@robrap robrap deleted the robrap/DEPR-USE-JWT-COOKIE branch August 29, 2024 12:27
@robrap
Copy link
Contributor Author

robrap commented Aug 29, 2024

@robrap since we are in transition to RV, we no longer own this code. Infinity is going to own this code so they can review it. thanks!

cc: @hurtstotouchfire

@abdullahwaheed: Did you mean to add this comment to one of the other "DEPR USE-JWT-COOKIE header" PRs? This one was for edx-platform, and arch-bom review is enough. Thanks.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

robrap added a commit that referenced this pull request Aug 29, 2024
@robrap
Revert "feat: DEPR USE-JWT-COOKIE header (#35393)"
cb003b6 
This reverts commit 1c2b804.
@robrap robrap mentioned this pull request Aug 29, 2024
Merged
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

dianakhuang pushed a commit that referenced this pull request Aug 29, 2024
@robrap
Revert "feat: DEPR USE-JWT-COOKIE header (#35393)" (#35397)
01c718d 
This reverts commit 1c2b804.
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@ormsbee ormsbee mentioned this pull request Sep 27, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmc-edx timmc-edx timmc-edx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robrap @abdullahwaheed @edx-pipeline-bot @timmc-edx