Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Spike Effort: Update version of Patternfly to v6 #3038

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Jul 26, 2024

Working on Spike: RHOAIENG-9577

Steps:

Update package.json to latest v6 versions and update the overrides (manually)
<commit 1>

Run the package install
npm i

Run code mods
npx @patternfly/pf-codemods@latest frontend/src/ --v6

Fix Code mods fail causes (manually)
<commit 2>

Re-Run code mods

npx @patternfly/pf-codemods@latest frontend/src/ --v6

npx @patternfly/pf-codemods@latest frontend/src/ --v6 —fix
<commit 3>

Fix Remaining Code Mod Errors (manually)
<commit 4>

Fix Lint Errors
npm run test:fix
<commit 5>

Manually fix remaining Lint Errors (manually)
<commit 6>

Run class-name-updater

npx @patternfly/class-name-updater --v6 frontend/src/ --fix
<commit 7>

Build attempt
npm run build

Fix remaining build issues (manually)
<commit 8>

Replace “—pf-v6-global—spacer” with “—pf-t—global—spacer”
<commit 9>

Home page fix (manually)
<commit 10>

image

Copy link
Contributor

openshift-ci bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added needs-rebase PR needs to be rebased and removed needs-rebase PR needs to be rebased labels Aug 21, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state needs-rebase PR needs to be rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants