Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS Overrides and references to PF tokens in RHOAI + PF6 WIP PR #183

Open
nicolethoen opened this issue Aug 26, 2024 · 2 comments
Open
Assignees

Comments

@nicolethoen
Copy link
Contributor

take @jeff-phillips-18 WIP PR and run with it. Any questions on where to look for overrides, Jeff can help point people in the right directions.

PRs could be opened again the WIP PR, or commits can be made directly into the PR, depending on level of comfort.

Once we've made significant progress on these updates, we will engage with UXD designers (likely Jenn Giardino and Simran Dhaliwal) to do a design review of the PR, to check that nothing is broken or poorly formatted following the migration.

@thatblindgeye thatblindgeye self-assigned this Aug 28, 2024
@thatblindgeye
Copy link
Collaborator

In AboutDialog, the styling of the Alert title looks off. Because it's rendered inside a Content component, there's margin-block-start styling being applied to the h4.pf-v6-c-alert__title element which pushes it down compared to the icon:
image

@thatblindgeye
Copy link
Collaborator

The custom Switch styling in frontend/src/app/App.scss needs to be updated, it's causing the Switch toggle to be misaligned due to the sizing update:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants
@nicolethoen @thatblindgeye and others