Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --raw compatible with --hide #486

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

PoQuatre
Copy link
Contributor

This PR closes #394

@coveralls
Copy link

Coverage Status

coverage: 99.142% (+0.008%) from 99.134%
when pulling 523a3fe on PoQuatre:main
into 3dc909a on open-cli-tools:main.

@PoQuatre
Copy link
Contributor Author

I did some tests on my side with a package I'm working on, and it seems to work without issues, although I'm not 100% sure if I haven't missed some edge cases as I am not super familiar with the tool and the codebase

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I don't think there's any edge case here, just some optimisations and nitpicks, but I can apply those after merging your contribution in.

@gustavohenke gustavohenke merged commit e52d984 into open-cli-tools:main Jul 3, 2024
21 checks passed
gustavohenke added a commit that referenced this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--hide param doesn't work with --raw output
3 participants