Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--hide param doesn't work with --raw output #394

Closed
top-kat opened this issue Nov 30, 2022 · 7 comments · Fixed by #486
Closed

--hide param doesn't work with --raw output #394

top-kat opened this issue Nov 30, 2022 · 7 comments · Fixed by #486

Comments

@top-kat
Copy link

top-kat commented Nov 30, 2022

I have tried:

concurrently --kill-others "npm run build:watch" "npm run start:pm2" -r --hide "0"
# OR 
concurrently --kill-others "npm run build:watch" "npm run start:pm2" -r --hide 0

But hiding works only when I remove the -r (raw) param.

Sorry if this is intended behavior.

@paescuj
Copy link
Collaborator

paescuj commented Nov 30, 2022

I can confirm that the hide option is ignored in raw mode, but I don't know whether this is intended or not.
Do you happen to know this @gustavohenke?
I'll gladly adjust this in a pull request, if it's not an intended behavior.

@gustavohenke
Copy link
Member

gustavohenke commented Dec 28, 2022

Why the bug happens I think sorta makes sense -- stdio is inherited from the parent when spawning the command:

...(raw && { stdio: 'inherit' as const }),

And it should probably be fixed, yes.

@fabiiomiiguel
Copy link

Hello @gustavohenke 😁 First of all, thank you for this amazing tool.

I'm here just to ask, if you plan to publish this fix anytime soon?

@gustavohenke
Copy link
Member

There's been no fix yet. PRs are welcome, if you have ideas!

@PoQuatre
Copy link
Contributor

Hello @gustavohenke I did a PR fixing this issue (#486) around 2 weeks ago, but it still has no responses, so I was wondering if PRs are still welcome for this?

@gustavohenke
Copy link
Member

gustavohenke commented Jul 3, 2024

It's merged 🙂

@gustavohenke
Copy link
Member

Hi folks, sorry for the delay, this is now done in v9.0.0.
https://github.com/open-cli-tools/concurrently/releases/tag/v9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants