Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all R scripts that require to disable the sandbox #24267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kit-ty-kate
Copy link
Member

See #23309 (comment)

This is a draft for now. Let's see if they all work without those script first.

@samoht
Copy link
Member

samoht commented Apr 2, 2024

I'm in favour of that one.

@shonfeder
Copy link
Collaborator

Hi, @kit-ty-kate :) Am I correct in understanding that this is a prerequisite for unblocking #23309? If the intent was to run the CI checks here, it will need a rebase: analysis is currently failing with

2024-06-20 06:04.17: Job failed: Cannot merge to master - please rebase!

@kit-ty-kate
Copy link
Member Author

Hi, @kit-ty-kate :) Am I correct in understanding that this is a prerequisite for unblocking #23309?

yes, both are related.

@kit-ty-kate kit-ty-kate marked this pull request as ready for review July 1, 2024 12:52
@shonfeder
Copy link
Collaborator

shonfeder commented Jul 23, 2024

Sorry if this is a noisesome ping, but it's not clear to me what the next steps are for this PR, assuming it is still relevant. Is it waiting on additional work from elsewhere, or is it just a matter of trying to get the CI to go through?

This PR is tagged with policy discusson, but I'm not sure what that discussion is.

@kit-ty-kate
Copy link
Member Author

This PR is tagged with policy discussion, but I'm not sure what that discussion is.

My first guess would be that it's a policy discussion because the package could hypothetically have worked on a setup with opam without sandbox. So the question might be "should opam-repository formally forbids packages that require to disable the sandbox in order to be installable?"

But @samoht might have more insights as to why it was labeled this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants