Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clear button for Select #2015

Merged
merged 30 commits into from
May 15, 2024
Merged

Add clear button for Select #2015

merged 30 commits into from
May 15, 2024

Commits on Apr 8, 2024

  1. Working implementation.

    @atmgrifter00
    atmgrifter00 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    fbc3739 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Update to spec.

    @atmgrifter00
    atmgrifter00 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    87173a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Cleanup, unit tests, and matrix tests.

    @atmgrifter00
    atmgrifter00 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f5d2430 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into clear-select

    @atmgrifter00
    atmgrifter00 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ea80908 View commit details
    Browse the repository at this point in the history

  3. Change files

    @atmgrifter00
    atmgrifter00 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    74a2e58 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'main' into clear-select

    @atmgrifter00
    atmgrifter00 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5e030f8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into clear-select

    @atmgrifter00
    atmgrifter00 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    e0c306d View commit details
    Browse the repository at this point in the history

  3. Merge fix.

    @atmgrifter00
    atmgrifter00 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4f4ea9a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Don't cache placeholder. Update tests.

    @atmgrifter00
    atmgrifter00 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c9359b8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into clear-select

    @atmgrifter00
    atmgrifter00 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f18a2ce View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into clear-select

    @atmgrifter00
    atmgrifter00 authored May 8, 2024
    Configuration menu
    Copy the full SHA
    2296afc View commit details
    Browse the repository at this point in the history

  4. Remove unused members.

    @atmgrifter00
    atmgrifter00 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5a0caf5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'clear-select' of https://github.com/ni/nimble into clea… 

    …r-select
    @atmgrifter00
    atmgrifter00 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    a8e422c View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Update packages/nimble-components/src/select/testing/select.pageobjec… 

    …t.ts

Co-authored-by: m-akinc <[email protected]>
    @atmgrifter00 @m-akinc
    atmgrifter00 and m-akinc authored May 9, 2024
    Configuration menu
    Copy the full SHA
    884c85e View commit details
    Browse the repository at this point in the history

  2. Handle PR feedback.

    @atmgrifter00
    atmgrifter00 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d4f9202 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'clear-select' of https://github.com/ni/nimble into clea… 

    …r-select
    @atmgrifter00
    atmgrifter00 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    07caa36 View commit details
    Browse the repository at this point in the history

  4. Handle PR feedback.

    @atmgrifter00
    atmgrifter00 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    44719b0 View commit details
    Browse the repository at this point in the history

  5. Slight test description change.

    @atmgrifter00
    atmgrifter00 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    84cbdd2 View commit details
    Browse the repository at this point in the history

  6. Handle PR feedback.

    @atmgrifter00
    atmgrifter00 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1086748 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Handle PR feedback.

    @atmgrifter00
    atmgrifter00 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5beb1ce View commit details
    Browse the repository at this point in the history

  2. Handle pressing Esc to clear value when dropdown is closed.

    @atmgrifter00
    atmgrifter00 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2d5b25d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into clear-select

    @atmgrifter00
    atmgrifter00 authored May 10, 2024
    Configuration menu
    Copy the full SHA
    84d6eb5 View commit details
    Browse the repository at this point in the history

  4. Handle PR feedback.

    @atmgrifter00
    atmgrifter00 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9a8143c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'clear-select' of https://github.com/ni/nimble into clea… 

    …r-select
    @atmgrifter00
    atmgrifter00 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9e8307e View commit details
    Browse the repository at this point in the history

  6. Update docs.

    @atmgrifter00
    atmgrifter00 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ae4fa8b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into clear-select

    @atmgrifter00
    atmgrifter00 authored May 10, 2024
    Configuration menu
    Copy the full SHA
    5228fbd View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'main' into clear-select

    @atmgrifter00
    atmgrifter00 authored May 13, 2024
    Configuration menu
    Copy the full SHA
    f329aa5 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Update packages/nimble-components/src/select/tests/select.spec.ts 

    Co-authored-by: Milan Raj <[email protected]>
    @atmgrifter00 @rajsite
    atmgrifter00 and rajsite authored May 15, 2024
    Configuration menu
    Copy the full SHA
    3e682d3 View commit details
    Browse the repository at this point in the history

  2. Handle PR feedback

    @atmgrifter00
    atmgrifter00 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f618689 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into clear-select

    @atmgrifter00
    atmgrifter00 authored May 15, 2024
    Configuration menu
    Copy the full SHA
    1aa2644 View commit details
    Browse the repository at this point in the history