Add clear button for Select #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
reviewed
May 8, 2024
There was a problem hiding this comment.
I found it difficult to reason about a lot of the select code (not necessarily the stuff related to this change). Particularly the interplay of value, displayValue, committedSelectedOption, firstSelectedOption, selectedIndex, and the selected attribute of the options. Hopefully my comments still make sense.
packages/nimble-components/src/select/testing/select.pageobject.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/select/testing/select.pageobject.ts
Outdated
Show resolved
Hide resolved
…t.ts Co-authored-by: m-akinc <[email protected]>
m-akinc
approved these changes
May 9, 2024
jattasNI
reviewed
May 10, 2024
jattasNI
reviewed
May 10, 2024
jattasNI
approved these changes
May 10, 2024
rajsite
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
👩💻 Implementation
Essentially just adding a button to the template of the
Selectthat will either set the selectedIndex to the option that represents the placeholder, or to -1 when there is no placeholder option, resulting in empty text for the display.🧪 Testing
Added unit and Chromatic tests.
✅ Checklist