Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3019 and #3162.
First #3162. The code has to deal with an
out_path
(always defined) and sometimes acache_path
too. The implementation was slightly convoluted as it was doing fresh downloads into thecache_path
orout_path
(first decision point) and then doing an extra copy if needed (second decision point). Because of that confusion, symlinks across container registries were not all created across both locations.I propose to reverse the logic to make it more straightforward:
out_path
and create its symlinks.cache_path
(and create symlinks there).Then, #3019: I propose to handle the singularity "library" directory this way:
--container-library-utilisation
parameter for the library because i)remote
would be redundant with the--container-cache-utilisation
'sremote
mode, ii)amend
is not possible as per the read-only rule, so iii)copy
is the only possible mode.singularity pull
. WhenNXF_SINGULARITY_LIBRARYDIR
is set and the container exists in the library, it is copied to the target directories (out_path
and possiblycache_path
too)PR checklist
CHANGELOG.md
is updatedREADME.md