Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(K8s): Added the configuration-guided step to the installation K8… #18479
base: develop
Are you sure you want to change the base?
feat(K8s): Added the configuration-guided step to the installation K8… #18479
Changes from 3 commits
fe20a43
82e2e20
0a1a2e6
a05d65a
f24ed33
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam We say there's a Kuberentes plugin for log forwarding, but we also say there's a Fluent Bit output plugin. It seems like these are two different names for the same thing, and is "plugin" the best term? Don't Kubenerntes plugins modify the Kubernetes cluster in some way? This Flurent Bit container is just forwarding logs, right?
I wonder if we should just drop "plugin" from the title and switch to something like this: "Forward Kubernetes log." If you did that, you'd have to rearrange the introduction and the Fluent Bit section.
Also, this doc repeats that confusing sentence: "New Relic has a Fluent Bit output plugin to forward your logs to New Relic log management. This plugin is also provided in a standalone Docker image that can be installed in a Kubernetes cluster in the form of a DaemonSet, also known as the Kubernetes plugin."
Again, aren't we just saying you can have two DaemonSets in your cluster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mangulonr, can you help us with the above and below comments, please? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam is all this information about metric data just applicable to the Helm chart version of the New Relic Fluent Bit Docker Container?