-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(K8s): Added the configuration-guided step to the installation K8… #18479
base: develop
Are you sure you want to change the base?
Conversation
Hi @nbaenam 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam thanks for working on this logging information! I inserted a few comments to consider.
src/content/docs/logs/forward-logs/kubernetes-plugin-log-forwarding.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam I took another pass through these docs. Let's chat about these changes.
...ernetes-pixie/kubernetes-integration/advanced-configuration/windows-linux-hybrid-cluster.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/logs/forward-logs/fluent-bit-plugin-log-forwarding.mdx
Outdated
Show resolved
Hide resolved
@@ -18,44 +18,11 @@ freshnessValidatedDate: never | |||
|
|||
New Relic's Kubernetes plugin for log forwarding simplifies sending logs from your cluster to New Relic logs. It uses a standalone Docker image and runs as a DaemonSet, seamlessly collecting logs for centralized analysis and troubleshooting. Forwarding your Kubernetes logs to New Relic will give you enhanced <InlinePopover type="logs" /> capabilities to collect, process, explore, query, and alert on your log data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam We say there's a Kuberentes plugin for log forwarding, but we also say there's a Fluent Bit output plugin. It seems like these are two different names for the same thing, and is "plugin" the best term? Don't Kubenerntes plugins modify the Kubernetes cluster in some way? This Flurent Bit container is just forwarding logs, right?
I wonder if we should just drop "plugin" from the title and switch to something like this: "Forward Kubernetes log." If you did that, you'd have to rearrange the introduction and the Fluent Bit section.
Also, this doc repeats that confusing sentence: "New Relic has a Fluent Bit output plugin to forward your logs to New Relic log management. This plugin is also provided in a standalone Docker image that can be installed in a Kubernetes cluster in the form of a DaemonSet, also known as the Kubernetes plugin."
Again, aren't we just saying you can have two DaemonSets in your cluster?
- One DaemonSet for the Kubernetes integration
- Another DaemonSet for the Fluent Bit Docker container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mangulonr, can you help us with the above and below comments, please? Thanks!
|
||
See [Fluent Bit plugin for log forwarding](/docs/logs/forward-logs/fluent-bit-plugin-log-forwarding) for more details about it. | ||
See [Fluent Bit plugin for log forwarding](/docs/logs/forward-logs/fluent-bit-plugin-log-forwarding) doc for more details about it. | ||
|
||
### Additional metric details [#addition-metric-details] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam is all this information about metric data just applicable to the Helm chart version of the New Relic Fluent Bit Docker Container?
Added a new step on how to enable and configure K8s logs within the branching component we have in the Install the Kubernetes integration doc.
Ticket: NR-267689