Calculate rewards weighted by hours spent #23
Conversation
| // console.debug('contributionsData:', contributionsData) | ||
|
|
||
| // Iterate every week from the week of [Sun May-29-2022 → Sun Jun-05-2022] until now | ||
| const weekEndDate = new Date('2022-06-05T00:00:00Z') |
There was a problem hiding this comment.
This had me scratching my head, because I am simple. Can we have a const like "the beginning of contribution time" defined somewhere and use that here instead, and how is it letting you change the time on the const date, the world is broken.
const theBeginningOfTime = new Date('2022-06-05T00:00:00Z')
let currentEndDate = theBeginningOfTime;
Go....
There was a problem hiding this comment.
Yeah, in all the other systems we use the week of 2022-05-22 as the beginning of time. So renaming would make sense. I made a separate issue for this: #24
| } else { | ||
| const reward = rewards[String(dataRow.passport_id)] | ||
| reward.hours_spent_total += Number(dataRow.hours_spent) | ||
| reward.hours_spent_total = Number(Number(reward.hours_spent_total).toFixed(2)) |
There was a problem hiding this comment.
This line is quite nuts, do you really have to do that?
let hours = +dataRow.hours_spent + dataRow.hours_spent_total hours = hours.toFixed(2) reward.hours_spent_total = hours
I dunnot maybe not worth it, jsut talk me while to read!
There was a problem hiding this comment.
This line is quite nuts, do you really have to do that?
let hours = +dataRow.hours_spent + dataRow.hours_spent_total hours = hours.toFixed(2) reward.hours_spent_total = hoursI dunnot maybe not worth it, jsut talk me while to read!
Hehe, I agree, nuts indeed 🤪
The reason for having it was just to store numbers as 1.95 instead of 1.95000000001. But I hope that there are more elegant solutions for solving this.
| const reward = rewards[passportID] | ||
| const rewardPercentage = 100 * reward.hours_spent_total / hoursSpentAllCitizens | ||
| reward.reward_percentage = Number(rewardPercentage.toFixed(2)) | ||
| }) |
@johnmark13 Yes, definitely. I made an issue for refactoring here: #25 |
close #7