Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine code for generating weekly rewards CSVs into one file #25

Open
aahna-ashina opened this issue Feb 6, 2024 · 0 comments
Open

Combine code for generating weekly rewards CSVs into one file #25

aahna-ashina opened this issue Feb 6, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@aahna-ashina
Copy link
Member

Reduce the duplicated code for generating weekly rewards CSVs for each guild.

          It was quite a cursory glance! I guess if I was being difficult the 4 processes all look very similar could one field have been triggered with a different parameter to work with the different data or would that have sucked? Then a couple of small comments...

Originally posted by @johnmark13 in #23 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aahna-ashina