-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cubase XML chord symbol import #24967
base: master
Are you sure you want to change the base?
Fix Cubase XML chord symbol import #24967
Conversation
Follow up to musescore#24915
I wonder if a more general approach is needed, such as letting |
Youz mean like this? int String::toInt(bool* ok, int base) const
{
ByteArray ba = simplified().toUtf8();
return static_cast<int>(toInt_helper(ba.constChar(), ok, base));
} |
I was actually thinking of something in Also, It may be better to use |
I'd prefer to use |
But I think we can't assume that those are the only places where we will ever encounter leading/trailing whitespace. The XML specification says that whitespace around numbers is allowed and should be ignored by the parser. More precisely,
|
As per https://www.w3.org/2021/06/musicxml40/musicxml-reference/data-types/semitones/ that makes up for 5 occurences in in importmxmlpass2.cpp. Still pretty managable, to be done individually there. |
Follow up to #637, `bass-alter` needs the same treatment as `root-alter` and some others too, as per musescore#24967 (comment)
But of course it does not only apply to the semitones type, but to basically all cases where a number has to be parsed from an XML tag's content. Hence my suggestion to make the change in |
It'd also be |
oops |
Yes, we should probably do this in |
As that uses |
Follow up to #24915
Resolves: #24865 and https://musescore.org/en/node/368990#comment-1260723