Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MusicXML import ignores chord accidentals in files created by Cubase #24865

Closed
4 tasks done
lvinken opened this issue Sep 22, 2024 · 3 comments · Fixed by #24915 · May be fixed by #24967
Closed
4 tasks done

MusicXML import ignores chord accidentals in files created by Cubase #24865

lvinken opened this issue Sep 22, 2024 · 3 comments · Fixed by #24915 · May be fixed by #24967
Assignees
Labels
MusicXML P2 Priority: Medium regression MS4 Regression on a prior release

Comments

@lvinken
Copy link
Contributor

lvinken commented Sep 22, 2024

Issue type

Import/export issue

Description with steps to reproduce

open file Untitled_score_xml_Cubase.xml (in attached zip file)
actual behaviour: both measures contain a B minor chord
expected behaviour: measure one contains a B chord, measure two contains a B minor chord

Supporting files, videos and screenshots

368990.zip

What is the latest version of MuseScore Studio where this issue is present?

master commit b86e642

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

macOS Sonoma 14.6.1

Additional context

Issue reported in https://musescore.org/en/node/368990. This is a MuseScore 4.4 regression, file Untitled_score_xml_Cubase.xml is handled correctly by MuseScore 3.6.2 and 4.3.

Root cause is that the "alter = m_e.readText().toInt();" in MusicXMLParserPass2::harmony() fails (silently). This is apparently cause by extra whitespace in the root-alter element. Notice the difference between both xml files in the zip.

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added the regression MS4 Regression on a prior release label Sep 22, 2024
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 22, 2024

So it is the dufference between the non-working

      <harmony print-frame="no">
        <root>
          <root-step>B</root-step>
          <root-alter>-1
          </root-alter>
          </root>
        <kind text="m">minor</kind>
        </harmony>

and the working

      <harmony print-frame="no">
        <root>
          <root-step>B</root-step>
          <root-alter>-1</root-alter>
          </root>
        <kind text="m">minor</kind>
        </harmony>

@Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz
Copy link
Contributor

bass-alter has the same issue, see https://musescore.org/en/node/368990#comment-1260723 and #24967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MusicXML P2 Priority: Medium regression MS4 Regression on a prior release
Projects
Status: Needs porting
6 participants