Added code to update submodules during installation #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code to automatically initialize and update all submodules recursively. This change addresses build errors related to un-initialized submodules, specifically issues with the `pybind11` submodule. The script checks each directory for the presence of `.gitmodules` and, if found, performs the necessary submodule updates. This ensures all dependencies are correctly set up before build, improving the reliability of our build process and reducing setup errors for new users.
sea-bass
requested changes
Aug 25, 2024
There was a problem hiding this comment.
As this is specific to only setting up submodules for the MoveIt Task Constructor python bindings, which are optional, I don't think this should take up more space in the default tutorials instructions.
But also, there is a simpler solution to all this, which is to add the --recursive flag to vcs import:
vcs import --recursive < moveit2_tutorials/moveit2_tutorials.repos
^ maybe this is okay to update?
Added --recursive flag to vcs import as per PR comments
|
@sea-bass Thanks. I didn't know this simpler option existed. I've updated the PR. |
sea-bass
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to automatically initialize and update all submodules recursively. This change addresses build errors related to un-initialized submodules, specifically issues with the
pybind11submodule. The script checks each directory for the presence of.gitmodulesand, if found, performs the necessary submodule updates. This ensures all dependencies are correctly set up before build, improving the reliability of our build process and reducing setup errors for new users.