-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release 03-07-2023] New UI Revamp and Max Storage Limit Handling #756
[Release 03-07-2023] New UI Revamp and Max Storage Limit Handling #756
Conversation
…ning storage is less than 20MB Issue Link https://mosip.atlassian.net/browse/INJI-151
The app will show error popup when the device's remaining storage is less than or equal to 20MB, hence reverting this Issue Link https://mosip.atlassian.net/browse/INJI-151
…rageLimitReached - remaining device storage less than or equal to 20MB Issue Link https://mosip.atlassian.net/browse/INJI-151
…r maximum storage limit is reached Issue Link https://mosip.atlassian.net/browse/INJI-151
…ate for the addVc state of MyVcsTabMachine Issue Link https://mosip.atlassian.net/browse/INJI-151
…ic for maximum storage limit Issue Link https://mosip.atlassian.net/browse/INJI-151
feat(INJI-151): display error popup when maximum storage limit (20MB) is reached Issue Link https://mosip.atlassian.net/browse/INJI-151
…r sucessfull transfer
Reason for sharing vc
…icate Permission popup issue.
…ip/inji into internal-release-03-07-23
[Internal-release-03-07-23] - Literals changes are done along with other missing texts in locals.
[Internal-release-03-07-23] - Fixed VC Sharing and VC Item Related Issues
…tour guide option and fix the tuvali version in about inji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the removed SelectStoreError from the vcItem machine is still in actions. Are we really don't need this?
Observed the same in RequestScreenController, ScanScreenController.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do need this changes, as this will be required for showing the maxStorageLimit error, when we try to receive vc , after the storage limit is reached
Fixes :
INJI-151 - Display disk full warning message when device space is >= 20 MB
NEW UI Enhancements :
In JIRA :
INJI-5 - As a resident I should be able to remove the card from the wallet using the option in kebab-popup.
INJI-8 - Able to expand the QR code in the details.
INJI-22 - As a resident able to choose the language among the implemented 6.
INJI-23 - Create a "Help-screen" on the home page.
INJI-55 - Set timer after sending the OTP.
Github-Board :
#312 - Qr login screens as per latest wireframes.
#462 - Splash Logo screen.
#463 - 4- intro screens (Onboarding overlays)
#464 - Choose language overlay in the settings screen.
#465 - Auth screens as per wireframes in the new UI.
#466 - Home screen changes.
#468 - Create a kebab popup on the home screen.
#469 - Scan & send Vc screens as per new UI wireframes.
#529 - Create downloading card popup on the home screen.
#681 - Kebab menu with the working options (Pin, Unpin, View Activity, Authentication, Remove card).
#682 - UI changes for VC, VC-details and Settings.