[Release 03-07-2023] Reverse Merge #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring idpass/main and mosip/main in sync
[DSD-1364] Added delete workflow in manual mode for inji repo.
[DSD-1364] Added token to the workflow for inji repo.
…into newUIChanges
INJI new UI/UX release
Reason for sharing vc
…icate Permission popup issue.
…ip/inji into internal-release-03-07-23
[Internal-release-03-07-23] - Literals changes are done along with other missing texts in locals.
[Internal-release-03-07-23] - Fixed VC Sharing and VC Item Related Issues
…tour guide option and fix the tuvali version in about inji
[Release 03-07-2023] New UI Revamp and Max Storage Limit Handling
vharsh
reviewed
Jul 6, 2023
Comment on lines
-87
to
+95
| keytool \ | ||
| -genkey -v \ | ||
| -storetype PKCS12 \ | ||
| -keyalg RSA \ | ||
| -keysize 2048 \ | ||
| -validity 10000 \ | ||
| -storepass $DEBUG_KEYSTORE_PASSWORD \ | ||
| -keypass $DEBUG_KEYSTORE_PASSWORD \ | ||
| -alias androiddebugkey \ | ||
| -keystore android/app/debug.keystore \ | ||
| -dname "CN=io.mosip.residentapp,OU=,O=,L=,S=,C=US" | ||
| env: | ||
| DEBUG_KEYSTORE_PASSWORD: '${{secrets.INJI_ANDROID_DEBUG_STOREPASS}}' | ||
|
|
||
| echo "$ANDROID_KEYSTORE_FILE" > release.keystore.b64 | ||
| base64 -d -i release.keystore.b64 > android/app/release.keystore | ||
| env: | ||
| ANDROID_KEYSTORE_FILE: ${{ secrets.INJI_ANDROID_RELEASE_KEYSTORE }} |
There was a problem hiding this comment.
@adityankannan-tw Please see if this change is not going to break anything
There was a problem hiding this comment.
@vharsh This is needed as we should use only release keystore from secrets to push to play store and not the debug one. This is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release PR :
mosip#756