-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated tqdm to print files/sec instead of it/sec #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use "individuals" as a unit
. Phenopackets do not necessarily have to only come from a file. Take Phenopacket Store as an example. There is one ZIP archive that is open and the phenopacket data is read from the archive file on the fly..
Oh! Yah, okay, should we do individual or patient? Since the start of the bar does say "Patients Created", using patient would make sense. |
Please alway replace the word "patient" with the work "individual". |
@pnrobinson |
@lnrekerle yes, the progress bar looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the progress prompt still needs to be aligned with the prompt from the PR messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is it.
Individuals Processed: 100%|██████████| 337/337 [01:38<00:00, 3.43individuals/s]
This is what the bar should look like now.
This will close #241