-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compatibility] Adding EXPIRETIME and PEXPIRETIME command #664
Open
Vijay-Nirmal
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
Vijay-Nirmal:new/expiretime-and-pexpiretime
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+520
−2
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -302,6 +302,72 @@ public unsafe GarnetStatus TTL<TContext, TObjectContext>(ref SpanByte key, Store | |
return GarnetStatus.NOTFOUND; | ||
} | ||
|
||
/// <summary> | ||
/// Get the absolute Unix timestamp at which the given key will expire. | ||
/// </summary> | ||
/// <typeparam name="TContext"></typeparam> | ||
/// <typeparam name="TObjectContext"></typeparam> | ||
/// <param name="key">The key to get the Unix timestamp.</param> | ||
/// <param name="storeType">The store to operate on</param> | ||
/// <param name="output">Span to allocate the output of the operation</param> | ||
/// <param name="context">Basic Context of the store</param> | ||
/// <param name="objectContext">Object Context of the store</param> | ||
/// <param name="milliseconds">when true the command to execute is PEXPIRETIME.</param> | ||
/// <returns>Returns the absolute Unix timestamp (since January 1, 1970) in seconds or milliseconds at which the given key will expire.</returns> | ||
public unsafe GarnetStatus EXPIRETIME<TContext, TObjectContext>(ref SpanByte key, StoreType storeType, ref SpanByteAndMemory output, ref TContext context, ref TObjectContext objectContext, bool milliseconds = false) | ||
where TContext : ITsavoriteContext<SpanByte, SpanByte, SpanByte, SpanByteAndMemory, long, MainSessionFunctions, MainStoreFunctions, MainStoreAllocator> | ||
where TObjectContext : ITsavoriteContext<byte[], IGarnetObject, ObjectInput, GarnetObjectStoreOutput, long, ObjectSessionFunctions, ObjectStoreFunctions, ObjectStoreAllocator> | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not simply call TTL and convert it to unix-time? |
||
int inputSize = sizeof(int) + RespInputHeader.Size; | ||
byte* pbCmdInput = stackalloc byte[inputSize]; | ||
|
||
byte* pcurr = pbCmdInput; | ||
*(int*)pcurr = inputSize - sizeof(int); | ||
pcurr += sizeof(int); | ||
(*(RespInputHeader*)pcurr).cmd = milliseconds ? RespCommand.PEXPIRETIME : RespCommand.EXPIRETIME; | ||
(*(RespInputHeader*)pcurr).flags = 0; | ||
|
||
if (storeType == StoreType.Main || storeType == StoreType.All) | ||
{ | ||
var status = context.Read(ref key, ref Unsafe.AsRef<SpanByte>(pbCmdInput), ref output); | ||
|
||
if (status.IsPending) | ||
{ | ||
StartPendingMetrics(); | ||
CompletePendingForSession(ref status, ref output, ref context); | ||
StopPendingMetrics(); | ||
} | ||
|
||
if (status.Found) return GarnetStatus.OK; | ||
} | ||
|
||
if ((storeType == StoreType.Object || storeType == StoreType.All) && !objectStoreBasicContext.IsNull) | ||
{ | ||
var objInput = new ObjectInput | ||
{ | ||
header = new RespInputHeader | ||
{ | ||
cmd = milliseconds ? RespCommand.PEXPIRETIME : RespCommand.EXPIRETIME, | ||
type = milliseconds ? GarnetObjectType.PExpiretime : GarnetObjectType.Expiretime, | ||
}, | ||
}; | ||
|
||
var keyBA = key.ToByteArray(); | ||
var objO = new GarnetObjectStoreOutput { spanByteAndMemory = output }; | ||
var status = objectContext.Read(ref keyBA, ref objInput, ref objO); | ||
|
||
if (status.IsPending) | ||
CompletePendingForObjectStoreSession(ref status, ref objO, ref objectContext); | ||
|
||
if (status.Found) | ||
{ | ||
output = objO.spanByteAndMemory; | ||
return GarnetStatus.OK; | ||
} | ||
} | ||
return GarnetStatus.NOTFOUND; | ||
} | ||
|
||
public GarnetStatus SET<TContext>(ref SpanByte key, ref SpanByte value, ref TContext context) | ||
where TContext : ITsavoriteContext<SpanByte, SpanByte, SpanByte, SpanByteAndMemory, long, MainSessionFunctions, MainStoreFunctions, MainStoreAllocator> | ||
{ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think that there's a need for these new types