Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Adding EXPIRETIME and EXPIRETIME command #664

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vijay-Nirmal
Copy link
Contributor

Adding EXPIRETIME and EXPIRETIME command to garnet

  • Add EXPIRETIME and EXPIRETIME command
  • Add Test cases
  • Add documentation

Open Question:

  1. For Object type, Should I create a single GarnetObjectType called Expiration instead of EXPIRETIME and PEXPIRETIME? The advantage will be that it will be a single generic implementation that can be reused for others in the future if required. The disadvantage is that there will be a slight performance penalty but no additional memory needed since values of Expiration, EXPIRETIME and PEXPIRETIME are long type, so we can do in-place override the value after recomputing the required value.

@TalZaccai TalZaccai self-requested a review September 18, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant