Only truncate AOF if all active stores are checkpointed #461
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
chenhao-ye
force-pushed
the
only-truncate-aof-if-checkpoint-both-stores
branch
from
6d7ebb1
to
dc6bc16
Compare
vazois
reviewed
Jun 13, 2024
chenhao-ye
force-pushed
the
only-truncate-aof-if-checkpoint-both-stores
branch
2 times, most recently
from
49af328
to
e7a4010
Compare
chenhao-ye
changed the title
chenhao-ye
force-pushed
the
only-truncate-aof-if-checkpoint-both-stores
branch
from
e7a4010
to
c7f7c05
Compare
|
Comments are addressed. |
chenhao-ye
force-pushed
the
only-truncate-aof-if-checkpoint-both-stores
branch
from
c7f7c05
to
200a609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AOF is truncated after checkpointing. However, truncation should only happen if both stores are checkpointed, since they share the same AOF. The current implementation can lose data if
storeTypeis notStoreType.All.This bug so far is not triggered because every caller is using
StoreType.All.