Only truncate AOF if both stores are checkpointed

microsoft · Jun 12, 2024 · 6d7ebb1 · 6d7ebb1
1 parent 66ebaa7
commit 6d7ebb1
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/libs/server/StoreWrapper.cs b/libs/server/StoreWrapper.cs
@@ -693,15 +693,19 @@ private async Task InitiateCheckpoint(bool full, CheckpointType checkpointType,
                     objectStoreCheckpointResult = await objectStore.TakeHybridLogCheckpointAsync(checkpointType, tryIncremental);
             }
 
-            // If cluster is enabled the replication manager is responsible for truncating AOF
-            if (serverOptions.EnableCluster && serverOptions.EnableAOF)
+            // Only truncate AOF if both stores are checkpointed
+            if (storeType == StoreType.All)
             {
-                clusterProvider.SafeTruncateAOF(storeType, full, CheckpointCoveredAofAddress, storeCheckpointResult.token, objectStoreCheckpointResult.token);
-            }
-            else
-            {
-                appendOnlyFile?.TruncateUntil(CheckpointCoveredAofAddress);
-                appendOnlyFile?.Commit();
+                // If cluster is enabled the replication manager is responsible for truncating AOF
+                if (serverOptions.EnableCluster && serverOptions.EnableAOF)
+                {
+                    clusterProvider.SafeTruncateAOF(storeType, full, CheckpointCoveredAofAddress, storeCheckpointResult.token, objectStoreCheckpointResult.token);
+                }
+                else
+                {
+                    appendOnlyFile?.TruncateUntil(CheckpointCoveredAofAddress);
+                    appendOnlyFile?.Commit();
+                }
             }
 
             if (objectStore != null)