Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates #34931

Closed
wants to merge 166 commits into from
Closed

Readme updates #34931

wants to merge 166 commits into from

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Sep 17, 2024

No description provided.

zadjii-msft and others added 30 commits August 27, 2024 09:34
* Moving plugin folder

* all .net now pointing to the tool ver prop

* fixing cpp proj

* consolidation of packages

* removing non root nuget config

* Update src/modules/cmdpal/ToolingVersions.props

---------

Co-authored-by: Mike Griese <[email protected]>
Getting more of the projects broken into into files. Based on #3
* updating namespace for common

* Adjusting folder structure now so we can do larger move
* Adding in exts

* modifying exts

* deleting outdated azure extentions

* removing x86
As in title.

I'm adding a `ExtensionObject<T>` object too. It doesn't _enforce_ anything. We can use it to wrap up things we get from extensions. You get the object back out with `.Unsafe`, which is a mental clue "this object might not live in this process". It'll at least give us a better clue of all the places where accessing the object might not totally be safe.

Also fixes a bug that makes cmdpal a bit more resilient to an extension dying and being reloaded. Just go to all apps & back, and presto, reload.
* makes `quit` not crash the app
* makes any close actually tell our extensions to exit

once again, thanks devhome folks
@niels9001 niels9001 changed the title [UX] Fluent Design Readme updates Sep 17, 2024
@niels9001 niels9001 closed this Sep 17, 2024
@niels9001 niels9001 deleted the niels9001/Fluent2 branch September 17, 2024 15:04
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (107)
accodingly
adaptivecards
adityar
affordances
agressive
Allman
amuid
Aot
apicontract
APPMODEL
asynchonously
AVery
builttoroam
Cantarell
cazamor
chrnguyen
CLSIDs
cmdpal
commandpalette
contextitems
contractversion
cppversion
cswin
Ctl
CVS
defaultlib
devpal
dic
Droid
duhowett
emoji
ESPN
extensionsdk
filterbox
Fira
Griese
gsl
harcoded
homies
HSSH
icf
icommandprovider
icondatatype
iextn
IGo
imgflip
implementaions
implmenting
inbox
INLINEPREFIX
inotifypropchanged
intederminate
isection
Keychain
kinda
leaveing
libraryincludes
libucrt
libucrtd
listitems
listpage
lmao
localappdata
LUQ
MBM
meme
memicmp
Microwavable
migrie
minwindef
mobileredirect
mtu
nicksnettravels
NOCOMM
NOMCX
nonspace
nullness
Poc
Podcasts
Puser
Rasterization
renamve
rsdk
seperately
seperators
SFBS
sharepoint
sooon
sourcedoc
Spongebob
spongebot
stdcpp
syncronously
TIcon
ucrt
ucrtd
vcxitems
VExtension
vkey
vulnerbilities
Wasdk
wic
wraprer
WUX
xclip
xdoc
ycombinator
Previously acknowledged words that are now absent applayout appsfolder cswinrt Emoji systemsettings SYSTEMWOW USEPOSITION USESIZE VKey WIC 🫥
Some files were automatically ignored 🙈

These sample patterns would exclude them:

^\Qsrc/modules/cmdpal/doc/initial-sdk-spec/list-elements-mock-002.pdn\E$
^\Qsrc/modules/cmdpal/exclusion.dic\E$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words and update file exclusions, you could run the following commands

... in a clone of the [email protected]:zadjii-msft/PowerToys.git repository
on the niels9001/Fluent2 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/10905756105/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (1897) from .github/actions/spell-check/expect.txt and unrecognized words (107)

Dictionary Entries Covers Uniquely
cspell:r/src/r.txt 543 1 1
cspell:cpp/src/people.txt 23 1
cspell:cpp/src/ecosystem.txt 51 1

Consider adding them (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries:
          cspell:r/src/r.txt
          cspell:cpp/src/people.txt
          cspell:cpp/src/ecosystem.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
Errors (4)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
ℹ️ binary-file 2
❌ check-file-path 397
❌ forbidden-pattern 3
ℹ️ non-alpha-in-dictionary 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants