Skip to content

Commit

Permalink
extensions too
Browse files Browse the repository at this point in the history
  • Loading branch information
@zadjii-msft
zadjii-msft committed Aug 27, 2024
1 parent b5bcbcc commit ac240df
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 24 deletions.
1 change: 0 additions & 1 deletion src/modules/cmdpal/extensions/AzureResourcesExtension/AzureResourcesExtension.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" />
<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240607001" />
<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.4" />
<Manifest Include="$(ApplicationManifest)" />
Expand Down
5 changes: 2 additions & 3 deletions src/modules/cmdpal/extensions/GitHubExtension/GitHubExtension.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" />
<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240607001" />
<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.4" />
<PackageReference Include="Microsoft.WindowsAppSDK"/>
<PackageReference Include="Microsoft.Windows.CsWinRT"/>
<Manifest Include="$(ApplicationManifest)" />
</ItemGroup>

Expand Down
5 changes: 2 additions & 3 deletions src/modules/cmdpal/extensions/HackerNewsExtension/HackerNewsExtension.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" />
<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240607001" />
<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.4" />
<PackageReference Include="Microsoft.WindowsAppSDK"/>
<PackageReference Include="Microsoft.Windows.CsWinRT"/>
<Manifest Include="$(ApplicationManifest)" />
</ItemGroup>

Expand Down
5 changes: 2 additions & 3 deletions src/modules/cmdpal/extensions/MediaControlsExtension/MediaControlsExtension.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" />
<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240607001" />
<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.4" />
<PackageReference Include="Microsoft.WindowsAppSDK"/>
<PackageReference Include="Microsoft.Windows.CsWinRT"/>
<Manifest Include="$(ApplicationManifest)" />
</ItemGroup>

Expand Down
5 changes: 2 additions & 3 deletions src/modules/cmdpal/extensions/ProcessMonitorExtension/ProcessMonitorExtension.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" />
<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240607001" />
<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.4" />
<PackageReference Include="Microsoft.WindowsAppSDK"/>
<PackageReference Include="Microsoft.Windows.CsWinRT"/>
<Manifest Include="$(ApplicationManifest)" />
</ItemGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/modules/cmdpal/extensions/SpongebotExtension/SpongebotCommandsProvider.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
using System.Runtime.InteropServices.WindowsRuntime;
using System.Text;
using System.Text.Json;
using System.Text.Json.Nodes;
using System.Threading.Tasks;
using System.Xml.Linq;
using ABI.System;
using Microsoft.UI;
using Microsoft.Windows.CommandPalette.Extensions;
using Microsoft.Windows.CommandPalette.Extensions.Helpers;
using Newtonsoft.Json.Linq;
using Windows.Foundation;
using Windows.Storage.Streams;

Expand Down Expand Up @@ -82,7 +82,7 @@ private static async Task<string> _GenerateMeme(string text) {
var client = new System.Net.Http.HttpClient();

var state = File.ReadAllText(StateJsonPath());
var jsonState = JObject.Parse(state);
var jsonState = JsonNode.Parse(state);

var bodyObj = new Dictionary<string, string>
{
Expand All @@ -99,7 +99,7 @@ private static async Task<string> _GenerateMeme(string text) {
var resp = await client.PostAsync("https://api.imgflip.com/caption_image", content);
var respBody = await resp.Content.ReadAsStringAsync();
// dynamic r = JsonSerializer.Deserialize(respBody);
JObject response = JObject.Parse(respBody);
var response = JsonNode.Parse(respBody);

// var url = r?.data?.url;
var url = response["data"]?["url"]?.ToString() ?? "";
Expand Down
6 changes: 2 additions & 4 deletions src/modules/cmdpal/extensions/SpongebotExtension/SpongebotExtension.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" />
<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240607001" />
<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.4" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Microsoft.WindowsAppSDK"/>
<PackageReference Include="Microsoft.Windows.CsWinRT"/>
<Manifest Include="$(ApplicationManifest)" />
</ItemGroup>

Expand Down
4 changes: 0 additions & 4 deletions ...oft.Windows.CommandPalette.Extensions/Microsoft.Windows.CommandPalette.Extensions.vcxproj
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\..\packages\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.props" Condition="Exists('..\..\packages\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.props')" />
<Import Project="..\..\packages\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.props" Condition="Exists('..\..\packages\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.props')" />
<Import Project="..\..\packages\Microsoft.Windows.CppWinRT.2.0.220531.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('..\..\packages\Microsoft.Windows.CppWinRT.2.0.220531.1\build\native\Microsoft.Windows.CppWinRT.props')" />
<PropertyGroup Label="Globals">
<CppWinRTOptimized>true</CppWinRTOptimized>
Expand Down Expand Up @@ -233,7 +232,6 @@
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Label="ExtensionTargets">
<Import Project="..\..\packages\Microsoft.Windows.CppWinRT.2.0.220531.1\build\native\Microsoft.Windows.CppWinRT.targets" Condition="Exists('..\..\packages\Microsoft.Windows.CppWinRT.2.0.220531.1\build\native\Microsoft.Windows.CppWinRT.targets')" />
<Import Project="..\..\packages\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.targets" Condition="Exists('..\..\packages\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.targets')" />
<Import Project="..\..\packages\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.targets" Condition="Exists('..\..\packages\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.targets')" />
</ImportGroup>
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
Expand All @@ -242,8 +240,6 @@
</PropertyGroup>
<Error Condition="!Exists('..\..\packages\Microsoft.Windows.CppWinRT.2.0.220531.1\build\native\Microsoft.Windows.CppWinRT.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.Windows.CppWinRT.2.0.220531.1\build\native\Microsoft.Windows.CppWinRT.props'))" />
<Error Condition="!Exists('..\..\packages\Microsoft.Windows.CppWinRT.2.0.220531.1\build\native\Microsoft.Windows.CppWinRT.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.Windows.CppWinRT.2.0.220531.1\build\native\Microsoft.Windows.CppWinRT.targets'))" />
<Error Condition="!Exists('..\..\packages\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.props'))" />
<Error Condition="!Exists('..\..\packages\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.Windows.SDK.BuildTools.10.0.22621.756\build\Microsoft.Windows.SDK.BuildTools.targets'))" />
<Error Condition="!Exists('..\..\packages\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.props'))" />
<Error Condition="!Exists('..\..\packages\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.WindowsAppSDK.1.5.240227000\build\native\Microsoft.WindowsAppSDK.targets'))" />
</Target>
Expand Down

1 comment on commit ac240df

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log or 📝 job summary for details.

Unrecognized words (102) 
accodingly
adaptivecards
adityar
affordances
agressive
Allman
amuid
Aot
apicontract
APPMODEL
asynchonously
AVery
builttoroam
Cantarell
cazamor
chrnguyen
CLSIDs
cmdpal
commandpalette
contextitems
contractversion
cppversion
cswin
CVS
defaultlib
devcmdpal
devpal
dic
Droid
duhowett
emoji
ESPN
extensionsdk
Fira
Griese
gsl
harcoded
homies
icf
icommandprovider
icondatatype
iextn
IGo
imgflip
implementaions
inbox
INLINEPREFIX
inotifypropchanged
intederminate
kinda
libraryincludes
libucrt
libucrtd
listitems
lmao
localappdata
LUQ
MBM
meme
memicmp
Microwavable
migrie
minwindef
mobileredirect
mtu
nicksnettravels
NOCOMM
NOMCX
nonspace
nullness
packagesource
Podcasts
Puser
Quicklinks
Rasterization
rsdk
seperately
seperators
SFBS
sharepoint
sharpcorner
sooon
sourcedoc
Spongebob
spongebot
stdcpp
syncronously
TIcon
ucrt
ucrtd
vcxitems
VExtension
vkey
vulnerbilities
wbin
wic
wikimedia
WSB
WUX
xclip
xdoc
ycombinator
Previously acknowledged words that are now absent applayout appsfolder Emoji systemsettings SYSTEMWOW USEPOSITION USESIZE VKey WIC 🫥
Some files were automatically ignored 🙈

These sample patterns would exclude them:

^\Qsrc/modules/cmdpal/exclusion.dic\E$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words and update file exclusions, you could run the following commands

... in a clone of the [email protected]:microsoft/PowerToys.git repository
on the dev/cmdpal/main branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/10580672355/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (1896) from .github/actions/spell-check/expect.txt and unrecognized words (102)

Dictionary Entries Covers Uniquely
cspell:r/src/r.txt 543 1 1
cspell:cpp/src/people.txt 23 1
cspell:cpp/src/ecosystem.txt 51 1

Consider adding them (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries:
          cspell:r/src/r.txt
          cspell:cpp/src/people.txt
          cspell:cpp/src/ecosystem.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
Errors (4)

See the 📜action log or 📝 job summary for details.

❌ Errors Count
ℹ️ binary-file 1
❌ check-file-path 216
❌ forbidden-pattern 5
ℹ️ non-alpha-in-dictionary 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Please sign in to comment.