Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Data diagnostics opt-in #34078

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

[WIP] Data diagnostics opt-in #34078

wants to merge 33 commits into from

Conversation

stefansjfw
Copy link
Collaborator

@stefansjfw stefansjfw commented Jul 31, 2024

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@stefansjfw
Copy link
Collaborator Author

\azp run

@stefansjfw
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

src/gpo/assets/PowerToys.admx Outdated Show resolved Hide resolved
src/gpo/assets/en-US/PowerToys.adml Outdated Show resolved Hide resolved
src/gpo/assets/en-US/PowerToys.adml Show resolved Hide resolved
@htcfreek
Copy link
Collaborator

htcfreek commented Aug 1, 2024

Existing issue is #964 and we could think about using the existing system gpo instead of creating our own.

@microsoft microsoft deleted a comment from github-actions bot Aug 1, 2024
@stefansjfw stefansjfw changed the title [WIP] Data diagnostics opt-in Data diagnostics opt-in Aug 1, 2024
@stefansjfw stefansjfw changed the title Data diagnostics opt-in [WIP] Data diagnostics opt-in Aug 5, 2024
@stefansjfw stefansjfw mentioned this pull request Aug 7, 2024
14 tasks

This comment has been minimized.

@stefansjfw stefansjfw force-pushed the stefan/opt_in_telem branch 6 times, most recently from 7a9b429 to 726b012 Compare August 13, 2024 11:12
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@htcfreek
Copy link
Collaborator

@stefansjfw
This PR conflicts with #33703. As I like to get #33703 in soon how would you like to work around?

  1. I make my PR ready and you updated the gpo information bar in your PR with the new icon.
  2. We make both ready as is and fix the icon later.
  3. I hold my PR until yours is merged.

I personally prefer option 1.

This comment has been minimized.

@@ -495,6 +495,16 @@
<decimal value="0" />
</disabledValue>
</policy>
<policy name="AllowDiagnosticData" class="Both" displayName="$(string.AllowDiagnosticData)" explainText="$(string.AllowDiagnosticDataDescription)" key="Software\Policies\PowerToys" valueName="AllowDataDiagnostics">
<parentCategory ref="GeneralSettings" />
<supportedOn ref="SUPPORTED_POWERTOYS_0_84_0" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR gets not in for the 0.84.0 release please update the supportedOn value for the next release and do not forget to update the admx version/revision too.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (13)
anr
Dstr
etw
evntrace
NEWFILE
PROCESSTRACE
QPC
TRACEHANDLE
tracerpt
vewng
wcsncpy
wnode
yyy
Previously acknowledged words that are now absent applayout appsfolder cswinrt ETW systemsettings SYSTEMWOW USEPOSITION USESIZE 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:microsoft/PowerToys.git repository
on the stefan/opt_in_telem branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/10909422371/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (1897) from .github/actions/spell-check/expect.txt and unrecognized words (13)

Dictionary Entries Covers Uniquely
cspell:r/src/r.txt 543 1 1
cspell:cpp/src/people.txt 23 1
cspell:cpp/src/ecosystem.txt 51 1

Consider adding them (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries:
          cspell:r/src/r.txt
          cspell:cpp/src/people.txt
          cspell:cpp/src/ecosystem.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 1

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants