Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Update GPO infobar icon, improve some pages and fix bugs #33703

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Jul 7, 2024

Merge after 0.84.0 release.


Summary of the Pull Request

This PR updates the icon of the GPO managed info bars to a lock symbol.

Additionally this PR

  • fixes Behavior of CmdNotFound page when policy is configured.
  • improves order of info bars on PowerOcr page.
  • improves order of info bars on VCM page.
  • fixes the Awake page to use the correct enabled state if it is GPO configured.

Important

PR Checklist

Detailed Description of the Pull Request / Additional comments

CmdNotFound module page

Old behavior
image

New behavior
image
image

PowerOCR page after change

image

VCM page after change

image

Validation Steps Performed

Local test build.

@htcfreek htcfreek self-assigned this Jul 7, 2024
@htcfreek htcfreek added Product-Settings The standalone PowerToys Settings application Status-Blocked We can't make progress due to a dependency or issue labels Jul 7, 2024

This comment has been minimized.

@htcfreek htcfreek marked this pull request as ready for review August 24, 2024 17:28
@htcfreek htcfreek changed the title [Settings] Update GPO infobar icon & improve some pages [Settings] Update GPO infobar icon, improve some pages and fix bugs Aug 24, 2024
@htcfreek htcfreek added Needs-Review This Pull Request awaits the review of a maintainer. and removed Status-Blocked We can't make progress due to a dependency or issue labels Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer. Product-Settings The standalone PowerToys Settings application
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant