Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update experimental incremental summary context to readonly properties #22492

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Open

Update experimental incremental summary context to readonly properties #22492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1347e43
Update experimental incremental summary context to readonly properties
tyler-cai-microsoft Sep 12, 2024
9b642e8
Api extractor
tyler-cai-microsoft Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../runtime/runtime-definitions/api-report/runtime-definitions.legacy.alpha.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,9 @@ export interface IEnvelope {

// @alpha
export interface IExperimentalIncrementalSummaryContext {
latestSummarySequenceNumber: number;
summaryPath: string;
summarySequenceNumber: number;
readonly latestSummarySequenceNumber: number;
readonly summaryPath: string;
readonly summarySequenceNumber: number;
}

// @alpha
Expand Down
6 changes: 3 additions & 3 deletions packages/runtime/runtime-definitions/src/summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ export interface IExperimentalIncrementalSummaryContext {
/**
* The sequence number of the summary generated that will be sent to the server.
*/
summarySequenceNumber: number;
readonly summarySequenceNumber: number;
/**
* The sequence number of the most recent summary that was acknowledged by the server.
*/
latestSummarySequenceNumber: number;
readonly latestSummarySequenceNumber: number;
/**
* The path to the runtime/datastore/dds that is used to generate summary handles
* Note: Summary handles are nodes of the summary tree that point to previous parts of the last successful summary
Expand All @@ -113,7 +113,7 @@ export interface IExperimentalIncrementalSummaryContext {
* more dependencies.
*/
// TODO: remove summaryPath
summaryPath: string;
readonly summaryPath: string;
}

/**
Expand Down
Loading