Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update experimental incremental summary context to readonly properties #22492

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tyler-cai-microsoft
Copy link
Contributor

Make the properties on IExperimentalIncrementalSummaryContext readonly as it does not makes sense for those values to be mutable.

@github-actions github-actions bot added area: runtime Runtime related issues base: main PRs targeted against main branch labels Sep 12, 2024
@tyler-cai-microsoft tyler-cai-microsoft requested review from CraigMacomber, a team, pragya91, markfields, jatgarg, kian-thompson and rajatch-ff and removed request for a team September 12, 2024 23:36
@tyler-cai-microsoft tyler-cai-microsoft requested a review from a team as a code owner September 12, 2024 23:56
@github-actions github-actions bot added the public api change Changes to a public API label Sep 12, 2024
Copy link
Contributor

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

http://localhost:1313/docs/start/quick-start/
- (3412:4) 'Node.js' => https://nodejs.org/en/download (connection failed)


Stats:
  402886 links
    3134 destination URLs
       2 URLs ignored
       1 warnings
       1 errors

 ELIFECYCLE  Command failed with exit code 1.

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.26 KB 460.29 KB +35 Bytes
azureClient.js 558.25 KB 558.29 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 261.02 KB 261.04 KB +14 Bytes
fluidFramework.js 401.41 KB 401.42 KB +14 Bytes
loader.js 134.24 KB 134.25 KB +14 Bytes
map.js 42.43 KB 42.44 KB +7 Bytes
matrix.js 146.58 KB 146.58 KB +7 Bytes
odspClient.js 525.54 KB 525.58 KB +49 Bytes
odspDriver.js 97.85 KB 97.87 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 163.3 KB 163.31 KB +7 Bytes
sharedTree.js 391.87 KB 391.88 KB +7 Bytes
Total Size 3.3 MB 3.3 MB +245 Bytes

Baseline commit: 12242cf

Generated by 🚫 dangerJS against 9b642e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants