Edit In Excel: Fix metadata generation bug when caption name uses en dash instead of em dash
#2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenLilleMand
changed the title
en dash instead of em dash
encimita
previously approved these changes
Sep 16, 2024
src/System Application/App/Edit in Excel/src/EditinExcelImpl.Codeunit.al
Show resolved
Hide resolved
github-actions
bot
added
the
Build: scripts & configs
DenLilleMand
force-pushed
the
private/mattinielsen/fix-metadata-generation-bug-2
branch
from
3a2ff2d
to
a351559
Compare
github-actions
bot
added
Build: Automation
DenLilleMand
force-pushed
the
private/mattinielsen/fix-metadata-generation-bug-2
branch
from
a351559
to
7075ac5
Compare
github-actions
bot
removed
the
Build: Automation
encimita
previously approved these changes
Sep 16, 2024
encimita
previously approved these changes
Sep 20, 2024
mazhelez
previously approved these changes
Sep 20, 2024
JesperSchulz
previously approved these changes
Sep 23, 2024
DenLilleMand
dismissed stale reviews from JesperSchulz, mazhelez, and encimita
via
6506607
JesperSchulz
approved these changes
Sep 23, 2024
encimita
approved these changes
Sep 23, 2024
DenLilleMand
deleted the
private/mattinielsen/fix-metadata-generation-bug-2
branch
DenLilleMand
added a commit
that referenced
this pull request
Sep 23, 2024
… dash` instead of `em dash` (#2032) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Apparently in the Norwegian translation and maybe other places captions use `en dash` instead of the traditional `em dash` , I'm not sure if this is on purpose but it does make our integrations a little more complicated to do nicely, e.g. now I will make sure we support it in Edit In Excel, but we could easily have other integrations that breaks on this or will have in the future. Can see the following two screenshots where the first line is using `em dash` and the second line is using `en dash`, where the `en dash` is encoded and the `em dash` is removed. Code:  Result:  #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#548471](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/548471/)
DenLilleMand
added a commit
that referenced
this pull request
Sep 23, 2024
… dash` instead of `em dash` (#2032) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Apparently in the Norwegian translation and maybe other places captions use `en dash` instead of the traditional `em dash` , I'm not sure if this is on purpose but it does make our integrations a little more complicated to do nicely, e.g. now I will make sure we support it in Edit In Excel, but we could easily have other integrations that breaks on this or will have in the future. Can see the following two screenshots where the first line is using `em dash` and the second line is using `en dash`, where the `en dash` is encoded and the `em dash` is removed. Code:  Result:  #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#548471](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/548471/)
This was referenced Sep 23, 2024
DenLilleMand
added a commit
that referenced
this pull request
Sep 23, 2024
…ses `en… (#2075) … dash` instead of `em dash` (#2032) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Apparently in the Norwegian translation and maybe other places captions use `en dash` instead of the traditional `em dash` , I'm not sure if this is on purpose but it does make our integrations a little more complicated to do nicely, e.g. now I will make sure we support it in Edit In Excel, but we could easily have other integrations that breaks on this or will have in the future. Can see the following two screenshots where the first line is using `em dash` and the second line is using `en dash`, where the `en dash` is encoded and the `em dash` is removed. Code:  Result:  #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#548471](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/548471/) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> [AB#550129](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/550129/)
DenLilleMand
added a commit
that referenced
this pull request
Sep 23, 2024
… dash in norway tenants v25 0 (#2076) … dash` instead of `em dash` (#2032) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Apparently in the Norwegian translation and maybe other places captions use `en dash` instead of the traditional `em dash` , I'm not sure if this is on purpose but it does make our integrations a little more complicated to do nicely, e.g. now I will make sure we support it in Edit In Excel, but we could easily have other integrations that breaks on this or will have in the future. Can see the following two screenshots where the first line is using `em dash` and the second line is using `en dash`, where the `en dash` is encoded and the `em dash` is removed. Code:  Result:  #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#548471](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/548471/) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#550127](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/550127/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apparently in the Norwegian translation and maybe other places captions use
en dashinstead of the traditionalem dash, I'm not sure if this is on purpose but it does make our integrations a little more complicated to do nicely, e.g. now I will make sure we support it in Edit In Excel, but we could easily have other integrations that breaks on this or will have in the future.
Can see the following two screenshots where the first line is using
em dashand the second line is usingen dash, where theen dashis encoded and theem dashis removed.Code:
Result:
Work Item(s)
Fixes AB#548471