-
Notifications
You must be signed in to change notification settings - Fork 148
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Edit In Excel: Fix metadata generation bug when caption name uses `en…
… dash` instead of `em dash` (#2032) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Apparently in the Norwegian translation and maybe other places captions use `en dash` instead of the traditional `em dash` , I'm not sure if this is on purpose but it does make our integrations a little more complicated to do nicely, e.g. now I will make sure we support it in Edit In Excel, but we could easily have other integrations that breaks on this or will have in the future. Can see the following two screenshots where the first line is using `em dash` and the second line is using `en dash`, where the `en dash` is encoded and the `em dash` is removed. Code: ![image](https://github.com/user-attachments/assets/ea84e70d-66ee-46e6-b031-8dde21471b4b) Result: ![image](https://github.com/user-attachments/assets/506dc9da-fc6d-46b3-aa43-ea47aded264d) #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#548471](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/548471/)
- Loading branch information
1 parent
1a67cfd
commit 1d9a164
Showing
2 changed files
with
64 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters