Nats registry action #120
Merged
Nats registry action #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <[email protected]>
jochumdev
reviewed
Jul 23, 2023
jochumdev
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using nats as service registry. When a service is restarting it wouldn't update the registry entry. Looking into it, this was because the nats registry only does a
"create"action when storing to nats. That means that existing entries are not overwritten.Since it looked like it was a deliberate decision to use
"create", this adds a configuration optionRegisterActionfor it. It can be used with"put"to update or create a new registry entry. It could also be used with"update"if one doesn't want to create new registry entries if they do not exist.The default is still
"create"so there are no breaking changes.