Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NATS registry caching services forever #6762

Closed
wkloucek opened this issue Jul 10, 2023 · 4 comments · Fixed by #6881
Closed

NATS registry caching services forever #6762

wkloucek opened this issue Jul 10, 2023 · 4 comments · Fixed by #6881
Assignees
Labels

Comments

@wkloucek
Copy link
Contributor

Describe the bug

When using the NATS service registry, we can get quite quickly in a broken state.

Steps to reproduce

Steps to reproduce the behavior:

  1. start the oCIS with NATS Helm chart example https://github.com/owncloud/ocis-charts/tree/master/deployments/ocis-nats
  2. restart the gateway pods: kubectl -n ocis rollout restart deploy gateway

Expected behavior

Requests will fail for ~30 seconds. Afterwards everything is fine.

Actual behavior

Requests will fail forever. The proxy will log IPs of the gone gateway pods. ocis version will discovery the current gateway services when run inside any pod.

Additional context

oCIS 3.1.0-next.2

@micbar
Copy link
Contributor

micbar commented Jul 10, 2023

Severity? Blue Ticket?

@wkloucek
Copy link
Contributor Author

Severity? Blue Ticket?

Not too pressing. Meanwhile I can use etcd but other projects may not. I guess ~ Feb 2024 would be nice.

@kobergj
Copy link
Collaborator

kobergj commented Jul 20, 2023

Needs an upstream fix in go-micro: https://github.com/go-micro/plugins/blob/v4/registry/nats/v1.2.1/v4/registry/nats/nats.go#L325 Change "create" to "put" (prolly we need a configuration for this) I'll file a PR

@kobergj kobergj self-assigned this Jul 20, 2023
@kobergj
Copy link
Collaborator

kobergj commented Jul 20, 2023

go-micro PR is here: micro/plugins#120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants