Move to ruff for linting and formatting in requirements and workflow file #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarionBWeinzierl
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
This looks fine. Just to mention: You are moving from 3.10 to 3.12 in the same PR, too. Do we need a separate issue for this, or is it fine in one?
Also, are we sure that we have caught all the occurences where pylint is ignored? I would have thought there are more?
|
I think in one as the use of python is so trivial here. I did a fresh clone and ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title after discussions with @MarionBWeinzierl around #75