fix XCALLOC() against GCC 14 -Wcalloc-transposed-args #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix use of XCALLOC() macro against GCC 14 directive -Wcalloc-transposed-args that makes GCC to complain with an warning/error trace message like the below when 1st argument is given by sizeof(). warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args] No functional changes. Signed-off-by: Etienne Carriere <[email protected]>
sjaeckel
approved these changes
Jun 26, 2024
etienne-lms
added a commit
to etienne-lms/optee_os
that referenced
this pull request
Jun 27, 2024
Fix use of XCALLOC() macro against GCC 14 directive -Wcalloc-transposed-args that makes GCC to complain with an warning/error trace message like: warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args] This change was proposed and merged in mainline libtomcrypt repository. No functional change. Link: libtom/libtomcrypt#647 Signed-off-by: Etienne Carriere <[email protected]> Acked-by: Gatien Chevallier <[email protected]> Reviewed-by: Jerome Forissier <[email protected]>
etienne-lms
added a commit
to etienne-lms/optee_os
that referenced
this pull request
Jun 27, 2024
Fix use of XCALLOC() macro against GCC 14 directive -Wcalloc-transposed-args that makes GCC to complain with an warning/error trace message like: warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args] This change was proposed and merged in mainline libtomcrypt repository. No functional change. Link: libtom/libtomcrypt#647 Signed-off-by: Etienne Carriere <[email protected]> Acked-by: Gatien Chevallier <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
jforissier
pushed a commit
to OP-TEE/optee_os
that referenced
this pull request
Jun 27, 2024
Fix use of XCALLOC() macro against GCC 14 directive -Wcalloc-transposed-args that makes GCC to complain with an warning/error trace message like: warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args] This change was proposed and merged in mainline libtomcrypt repository. No functional change. Link: libtom/libtomcrypt#647 Signed-off-by: Etienne Carriere <[email protected]> Acked-by: Gatien Chevallier <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
jforissier
pushed a commit
to OP-TEE/optee_os
that referenced
this pull request
Jun 27, 2024
Fix use of XCALLOC() macro against GCC 14 directive -Wcalloc-transposed-args that makes GCC to complain with an warning/error trace message like: warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args] This change was proposed and merged in mainline libtomcrypt repository. No functional change. Link: libtom/libtomcrypt#647 Signed-off-by: Etienne Carriere <[email protected]> Acked-by: Gatien Chevallier <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix use of XCALLOC() macro against GCC 14 directive -Wcalloc-transposed-args that makes GCC to complain with an warning/error trace message like the below when 1st argument is given by sizeof().
warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args]No functional changes.
We experienced this issue building OP-TEE OS (https://github.com/OP-TE/optee_os.git, that host libtomcrypt library) with latest Yocto Styhead that uses GCC 14.1.
Checklist