fix use of calloc() against GCC 14.1 directive -Wcalloc-transposed-args #6912
Conversation
|
|
|
By the way, when issues are found in an external component, what are the steps to follow? |
|
I think the issue should be fixed in both: in the original component and in OP-TEE. Fixing the original component does not means OP-TEE should upgrade to the latest (fixed) release of that component which may have other implication. Picking the fix can be enough. For the very case of this change, as it is quite simple, libtom/libtomcrypt#647 has been quite quickly merged. I think it ok we only pick the fix, as proposed in this P-R. Maybe should I refer to libtom/libtomcrypt#647 (or to libtom/libtomcrypt@2302a3a) in the commit message. For info: the checkpatch warning report is due to the build error trace message that exceeds 75 char/line in the commit message. |
Yes, please. |
|
One minor thing: for the second commit, I'd rather use the |
|
I've updated the commit messages and applied posted review tags. |
|
|
Fix calloc() calls against GCC 14 directive -Wcalloc-transposed-args that makes GCC to complain with an warning/error trace message like: warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args] No functional change. Signed-off-by: Etienne Carriere <[email protected]> Acked-by: Gatien Chevallier <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
Fix use of XCALLOC() macro against GCC 14 directive -Wcalloc-transposed-args that makes GCC to complain with an warning/error trace message like: warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args] This change was proposed and merged in mainline libtomcrypt repository. No functional change. Link: libtom/libtomcrypt#647 Signed-off-by: Etienne Carriere <[email protected]> Acked-by: Gatien Chevallier <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
|
FYI I have cherry-picked the |
This change complements #6853.
Changes in libtomcrypt are under review in libtom/libtomcrypt#647.
No functional changes.