Improve Chinese Language Support & Fix Issue with Asset File Names #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kinostrome I've rebased the previous changes into |
Bardreamaster
force-pushed
the
fix_poster_details
branch
from
8ae793d
to
8a57916
Compare
Kinostrome
approved these changes
Aug 18, 2023
starjustice
added a commit
that referenced
this pull request
Sep 25, 2023
* sync latest version 2 changes (alpha) * Bug fix: Fix an error with the Topic and Post image URL when using a shortUrl as the source. * Bug fix: Post preview with a short URL uploads an image as the source. * add tool version, fixing nodejs to version 16 * fix quickstart command * fix react version due to expo request * Sync latest version 2 (alpha) * Sync latest version 2 (alpha) * Sync latest version 2 (alpha) * Sync latest version 2 (alpha) * Sync latest version 2 (alpha) * Sync latest version 2 (alpha) * Sync latest version 2 (alpha) * Sync latest version 2 (alpha) * Ensure that Github Actions runs on alpha-v2 as well (#46) Co-authored-by: Kinostrome <[email protected]> * Improve Chinese Language Support & Fix Issue with Asset File Names (#47) * fix assets name * fix getting poster ditails for different language --------- Co-authored-by: jinqi.wei <[email protected]> * Sync latest version 2 (alpha) * Sync latest version 2 (alpha) * Sync latest version 2 (alpha) * Sync latest version 2 (beta) * Sync latest version 2 --------- Co-authored-by: Simon Biggs <[email protected]> Co-authored-by: Gabriella Putri <[email protected]> Co-authored-by: Kinostrome <[email protected]> Co-authored-by: Kinostrome <[email protected]> Co-authored-by: ShiChangshan <[email protected]> Co-authored-by: jinqi.wei <[email protected]>
Bardreamaster
added a commit
to Bardreamaster/robook-forum
that referenced
this pull request
Nov 29, 2023
…exiconhq#47) * fix assets name * fix getting poster ditails for different language --------- Co-authored-by: jinqi.wei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
style:andperf:commits)Description
Reopen PR #44
In
fronted APP, the icons be imported using capitalized filename in frontend/src/icons.ts：But the filename is lowercase. So it causes error on fronted APP:
So we have to unify naming to avoid import error.
1.** Fix Simplified Chinese keywords for
getPosterTypeDetails.**Changes
Assets name
Fix asset import issue by renaming the following files:
Additional Screenshots
Nope.
Additional information/context
Tested on Discourse site in Chinese. (https://forum.robook.org)