Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new remoteva binary #7437

Merged
merged 24 commits into from
May 6, 2024
Merged

Add a new remoteva binary #7437

merged 24 commits into from
May 6, 2024

Conversation

pgporada
Copy link
Member

@pgporada pgporada commented Apr 17, 2024

  • Adds a new remoteva binary that takes a distinct configuration from the existing boulder-va
  • Removed the boulder-remoteva name registration from boulder-va.
    • Existing users of boulder-remoteva must either
      1. laterally migrate to boulder-va which uses that same config, or
      2. switch to using remoteva with a new config.

Part of #5294

@pgporada pgporada marked this pull request as ready for review April 17, 2024 21:13
@pgporada pgporada requested a review from a team as a code owner April 17, 2024 21:13
Copy link
Contributor

@pgporada, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

@pgporada pgporada requested review from jsha and aarongable and removed request for beautifulentropy April 17, 2024 21:13
@pgporada
Copy link
Member Author

Config change ticket: IN-10231

@pgporada pgporada changed the title Separate RVA from the VA Add a new boulder-remoteva2 binary Apr 18, 2024
cmd/boulder-remoteva/main.go Outdated Show resolved Hide resolved
cmd/boulder-remoteva/main.go Outdated Show resolved Hide resolved
jsha
jsha previously approved these changes Apr 19, 2024
cmd/boulder-remoteva/main.go Outdated Show resolved Hide resolved
cmd/boulder-remoteva/main_test.go Outdated Show resolved Hide resolved
cmd/config.go Show resolved Hide resolved
test/config-next/remoteva2-a.json Outdated Show resolved Hide resolved
test/config/va-remote-a.json Show resolved Hide resolved
test/startservers.py Outdated Show resolved Hide resolved
test/startservers.py Outdated Show resolved Hide resolved
va/config/config_test.go Outdated Show resolved Hide resolved
cmd/boulder-remoteva/main.go Outdated Show resolved Hide resolved
@pgporada pgporada changed the title Add a new boulder-remoteva2 binary Add a new boulder-rva binary Apr 23, 2024
@pgporada pgporada changed the title Add a new boulder-rva binary Add a new boulder-remoteva binary Apr 24, 2024
@pgporada pgporada changed the title Add a new boulder-remoteva binary Add a new remoteva binary Apr 25, 2024
Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I have just a few comments right off the top, I'm going to dive into the mTLS bits now.

cmd/boulder-va/main.go Show resolved Hide resolved
cmd/boulder-va/main.go Outdated Show resolved Hide resolved
cmd/boulder-va/main.go Outdated Show resolved Hide resolved
test/hierarchy/README.md Outdated Show resolved Hide resolved
cmd/remoteva/main.go Outdated Show resolved Hide resolved
cmd/config.go Outdated Show resolved Hide resolved
@pgporada pgporada merged commit c1561b0 into main May 6, 2024
12 checks passed
@pgporada pgporada deleted the 5294-split-va-and-rva branch May 6, 2024 20:29
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this pull request May 30, 2024
* Adds a new `remoteva` binary that takes a distinct configuration from
the existing `boulder-va`
* Removed the `boulder-remoteva` name registration from `boulder-va`. 
  * Existing users of `boulder-remoteva` must either 
1. laterally migrate to `boulder-va` which uses that same config, or
    2. switch to using `remoteva` with a new config.

Part of letsencrypt#5294
AlinaADmi pushed a commit to plesk/boulder that referenced this pull request Jul 29, 2024
* Adds a new `remoteva` binary that takes a distinct configuration from
the existing `boulder-va`
* Removed the `boulder-remoteva` name registration from `boulder-va`. 
  * Existing users of `boulder-remoteva` must either 
1. laterally migrate to `boulder-va` which uses that same config, or
    2. switch to using `remoteva` with a new config.

Part of letsencrypt#5294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants