-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remoteva: Config options to handle alternate deployment models #7473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgporada
changed the title
remoteva: Separate TLS client and server configs
va: Separate TLS client and server configs
May 7, 2024
aarongable
reviewed
May 9, 2024
pgporada
changed the title
va: Separate TLS client and server configs
va/remoteva: Config options to handle alternate deployment models
May 10, 2024
pgporada
force-pushed
the
separate-tls-client-and-server
branch
from
May 10, 2024 17:13
bd2b4e2
to
deb62c1
Compare
@pgporada, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
Related SRE tickets: |
beautifulentropy
requested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change LGTM, I just have some questions and docs nits.
Co-authored-by: Samantha <[email protected]>
beautifulentropy
previously approved these changes
May 13, 2024
aarongable
reviewed
May 13, 2024
beautifulentropy
approved these changes
May 13, 2024
aarongable
approved these changes
May 13, 2024
pgporada
changed the title
va/remoteva: Config options to handle alternate deployment models
remoteva: Config options to handle alternate deployment models
May 13, 2024
2 tasks
vbaranovskiy-plesk
pushed a commit
to plesk/boulder
that referenced
this pull request
May 30, 2024
…ncrypt#7473) * Adds a `VerifyGRPCClientCertIfGiven` boolean to the `remoteva` config that cause the RVA server to use the less strict `tls.VerifyClientCertIfGiven` for use with an Amazon Web Services Application Load Balancer (ALB) between the `boulder-va` and `remoteva`. See letsencrypt#7386. Part of letsencrypt#5294 --------- Co-authored-by: Samantha <[email protected]>
AlinaADmi
pushed a commit
to plesk/boulder
that referenced
this pull request
Jul 29, 2024
…ncrypt#7473) * Adds a `VerifyGRPCClientCertIfGiven` boolean to the `remoteva` config that cause the RVA server to use the less strict `tls.VerifyClientCertIfGiven` for use with an Amazon Web Services Application Load Balancer (ALB) between the `boulder-va` and `remoteva`. See letsencrypt#7386. Part of letsencrypt#5294 --------- Co-authored-by: Samantha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VerifyGRPCClientCertIfGiven
boolean to theremoteva
config that cause the RVA server to use the less stricttls.VerifyClientCertIfGiven
for use with an Amazon Web Services Application Load Balancer (ALB) between theboulder-va
andremoteva
. See Support using an ALB between VA and RVA #7386.Part of #5294