lthooks: new show related tests to fix issue #1243 #1248
+1,043
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaurens
force-pushed
the
lthooks-new-showhook-Fix-#1243
branch
from
266d42a
to
85fb3a5
Compare
6 tasks
jlaurens
force-pushed
the
lthooks-new-showhook-Fix-#1243
branch
2 times, most recently
from
99f5d8b
to
d212bc2
Compare
|
This PR looks reasonable to me - but could you rebase onto develop? |
- `lthooks-show-2020-10-01.lvt` is frozen at the 2020-10-01 release, no arguments in hooks - `update-lthooks-tests.sh` includes the above test - `lthooks-show.sty` is a library of test helpers. They will be used by forthcoming tests, as well as completed.
jlaurens
force-pushed
the
lthooks-new-showhook-Fix-#1243
branch
from
d212bc2
to
ab633a9
Compare
|
Done |
josephwright
requested review from
josephwright
and removed request for
PhelypeOleinik
muzimuzhi
reviewed
Jun 4, 2024
Comment on lines
-6789
to
-6790
| % \changes{v1.1h}{2024/01/24} | ||
| % {Correct usage of older \cs{@@_if_file_hook:wTF} (gh/1243)} |
There was a problem hiding this comment.
This deletion looks wired.
There was a problem hiding this comment.
I think it's spurious: will vanish when properly rebased
There was a problem hiding this comment.
I think it's spurious: will vanish when properly rebased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lthooks-show_2020-10-01.lvtis frozen at the 2020-10-01 release, no arguments in hooksupdate-lthooks-tests.shincludes the above testlthooks-show.styis a library of test helpers. They will be used by forthcoming tests, as well as completed.This is a fix in the 2020-10-01 rollback, tagged as
\changed{1.0w}. No actual version change though.All the config-lthooks and config-lthooks2 checks passed.
READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.
Pull requests in this repository are intended for LaTeX Team members only.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated