Lthooks new showhook 2 #1249
Open
Lthooks new showhook 2 #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaurens
force-pushed
the
lthooks-new-showhook-2
branch
2 times, most recently
from
4267744
to
e366eb5
Compare
|
Test names conform to other frozen tests names. |
6 tasks
jlaurens
force-pushed
the
lthooks-new-showhook-2
branch
3 times, most recently
from
cbd4ce2
to
e71fe05
Compare
|
I'm not sure I see the difference between this PR and #1248 in a functional sense: could you explain a bit more? |
|
PR 1248 has some tests frozen to the 2020 release whereas this one has some more tests frozen to the 2023 release. |
|
Maybe one dedicated branch for this PR and the forthcoming ones before everything is organized into bigger commits and merged to develop |
- `lthooks-show-2020-10-01.lvt` is frozen at the 2020-10-01 release, no arguments in hooks - `update-lthooks-tests.sh` includes the above test - `lthooks-show.sty` is a library of test helpers. They will be used by forthcoming tests, as well as completed.
- tests for arguments - show test file frozen for the 2023-06-01 release - show test file for the latest release, will be used to change `\ShowHook` in a forthcoming PR No date change, no code change
jlaurens
force-pushed
the
lthooks-new-showhook-2
branch
from
e71fe05
to
d123529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\ShowHookin a forthcoming PRNo date change, no code change
2 commits, the first one is the same as in PR #1248
Pull requests in this repository are intended for LaTeX Team members only.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated