Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4603: tune crashloopbackoff for 1.32 #4893

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

KEP-4603: tune crashloopbackoff for 1.32 #4893

wants to merge 24 commits into from
+577 −237

Conversation

lauralorenz
Copy link
Contributor

  • One-line PR description: Tunable CrashLoopBackoff proposal for 1.32 based on new defaults and node level (via kubelet flag) max backoff configuration
  • Other comments:

@lauralorenz
Update proposal and risk section for 1.32
00d1011 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add refactor for backoff counter reset threshold, and resolve major d…
1273fbd 
…esign details

Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Cleanup TODO and lingering unresolved tag
978d99d 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Reformatting some paragraphs
1461b6a 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update kubelet overhead analysis
03c1284 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
rewrap
83ca22b 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update more per node details
fb56335 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Specify kubelet configuration implementation
e0f35ba 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update graduation criteria with 1.32 proposal stuff
a4412ed 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update with conflict resolution info
21caaa6 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Internal consistency and proofreading run
c9f7bad 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add some new unresolved tags from IRL comments
c3d9e2c 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Clean up some unresolved's to undraft
b879c7f 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update graphs, remove some other unresolveds
0293f6f 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add new graphs
9229a7d 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add conflict resolution table
a31f622 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Fix napkin math in risks and mitigations
5a50201 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Address free restart issue in design details
154a5c9 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Fix some lingering unresolveds
ea3988f 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Remove benchmarking ifftt, can add later
97cb477 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update toc
d81363d 
Signed-off-by: lauralorenz <[email protected]>
@lauralorenz
spelling
40073eb 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
update some grad criteria and version skew info
5997b34 
Signed-off-by: Laura Lorenz <[email protected]>
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lauralorenz
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 2, 2024
@lauralorenz lauralorenz mentioned this pull request Oct 2, 2024
Closed
@lauralorenz lauralorenz marked this pull request as ready for review October 2, 2024 04:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2024
@lauralorenz lauralorenz mentioned this pull request Oct 2, 2024
Merged
@soltysh
Copy link
Contributor

soltysh commented Oct 2, 2024

I'll play the broken record, but you're missing https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/template/nnnn.yaml 😅 - drop my name there, as the approver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Node PR Triage
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lauralorenz @k8s-ci-robot @soltysh