Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Create trigger validation test for custom migration targets and custom rules #1213
[RFR] Create trigger validation test for custom migration targets and custom rules #1213
Changes from all commits
0af2a53
d997f51
95ab80d
a2fbf5d
408927e
dc1476a
6ec0bcc
eb9d153
2856dc3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abrugaro I also want to validate that the custom rule is triggered not just the effort .
We can use the same app from the bug MTA-3330 if needed , https://github.com/selrahal/mta-bug and check if custom rule is triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sshveta Here I'm running the analysis using the custom rules from the bug (https://github.com/selrahal/mta-bug) I just uploaded the same rules to the bookserver repo to have everything together (https://github.com/ibraginsky/book-server/tree/main/bug-3330-rules).
Since I'm analyzing the app with just these rules, validating the effort is equivalent to validate the triggering of the rules because I analyze both apps with the same rules that should be equally triggered, hence, report the same effort.