Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Create trigger validation test for custom migration targets and custom rules #1213

Merged
merged 9 commits into from
Sep 4, 2024

Conversation

abrugaro
Copy link
Collaborator

@abrugaro abrugaro commented Sep 2, 2024

Solves MTA-3590 by automating bug MTA-3330

This test aims to check that the same rules are triggered and the same violations are created when analyzing two different apps, one using a custom migration target with rules fetched from a remote git repository and another one with no target but custom rules specified in the same way.

Polarion TC 597

Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Copy link
Contributor

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kpunwatk kpunwatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

applications.forEach((app) => {
app.verifyAnalysisStatus(AnalysisStatuses.completed);
Application.open(true);
app.verifyEffort(EXPECTED_EFFORT);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abrugaro I also want to validate that the custom rule is triggered not just the effort .
We can use the same app from the bug MTA-3330 if needed , https://github.com/selrahal/mta-bug and check if custom rule is triggered.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sshveta Here I'm running the analysis using the custom rules from the bug (https://github.com/selrahal/mta-bug) I just uploaded the same rules to the bookserver repo to have everything together (https://github.com/ibraginsky/book-server/tree/main/bug-3330-rules).

Since I'm analyzing the app with just these rules, validating the effort is equivalent to validate the triggering of the rules because I analyze both apps with the same rules that should be equally triggered, hence, report the same effort.

@sshveta sshveta merged commit 899f771 into konveyor:main Sep 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants