-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Create trigger validation test for custom migration targets and custom rules #1213
Conversation
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
…to automate-mta-bug-3330
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
cypress/e2e/tests/administration/custom-migration-targets/trigger_validation.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
applications.forEach((app) => { | ||
app.verifyAnalysisStatus(AnalysisStatuses.completed); | ||
Application.open(true); | ||
app.verifyEffort(EXPECTED_EFFORT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abrugaro I also want to validate that the custom rule is triggered not just the effort .
We can use the same app from the bug MTA-3330 if needed , https://github.com/selrahal/mta-bug and check if custom rule is triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sshveta Here I'm running the analysis using the custom rules from the bug (https://github.com/selrahal/mta-bug) I just uploaded the same rules to the bookserver repo to have everything together (https://github.com/ibraginsky/book-server/tree/main/bug-3330-rules).
Since I'm analyzing the app with just these rules, validating the effort is equivalent to validate the triggering of the rules because I analyze both apps with the same rules that should be equally triggered, hence, report the same effort.
Solves MTA-3590 by automating bug MTA-3330
This test aims to check that the same rules are triggered and the same violations are created when analyzing two different apps, one using a custom migration target with rules fetched from a remote git repository and another one with no target but custom rules specified in the same way.
Polarion TC 597