Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default ADDRESS env var on deploy #1837

Merged
merged 1 commit into from
Jul 12, 2023

adds ADDRESS env to deployed

1f62a31
Select commit
Loading
Failed to load commit list.
Merged

feat: default ADDRESS env var on deploy #1837

adds ADDRESS env to deployed
1f62a31
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 28, 2023 in 0s

63.53% (+1.02%) compared to b6b15f9

View this Pull Request on Codecov

63.53% (+1.02%) compared to b6b15f9

Details

Codecov Report

Patch coverage: 82.35% and project coverage change: +1.02 🎉

Comparison is base (b6b15f9) 62.51% compared to head (1f62a31) 63.53%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   62.51%   63.53%   +1.02%     
==========================================
  Files         107      107              
  Lines       13732    13749      +17     
==========================================
+ Hits         8585     8736     +151     
+ Misses       4331     4172     -159     
- Partials      816      841      +25
Impacted Files Coverage Δ
pkg/knative/deployer.go 64.23% <82.35%> (+0.43%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

View more details on Codecov